Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an advanced shield field upgrade for the UEF ACU #6184

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented May 14, 2024

Description of the proposed changes

The prerequisite for this upgrade is the shield field.

AdvancedShieldGeneratorField

BuildCostEnergy = 110000,
BuildCostMass = 2200,
BuildTime = 2200,
ShieldMaxHealth = 20000,
ShieldRechargeTime = 120,
ShieldRegenRate = 80,

Checklist

  • Make the upgrade functional.
  • Evaluate the balance impact of the changes (will need testing in real games).
  • Add new localizations.
  • Changes are documented in the changelog for the next game version.

@Basilisk3
Copy link
Collaborator Author

Basilisk3 commented May 14, 2024

If the balance team decides that this is something we want, a unique icon for the upgrade is going to be needed.

@Basilisk3 Basilisk3 changed the title Introduce an additional shield field upgrade for the UEF ACU Introduce an advanced shield field upgrade for the UEF ACU May 14, 2024
@MrRowey MrRowey added area: balance related to units balance DO NOT MERGE Don't Merge until removed labels May 14, 2024
@Garanas Garanas changed the base branch from deploy/fafdevelop to develop June 1, 2024 19:30
@MrRowey
Copy link
Member

MrRowey commented Jul 9, 2024

Closing this Pr for now as we need to see how the new Implementation of the cheaper shield works out first

@MrRowey MrRowey closed this Jul 9, 2024
@MrRowey MrRowey reopened this Jul 9, 2024
@MrRowey MrRowey marked this pull request as draft July 9, 2024 11:06
@Basilisk3
Copy link
Collaborator Author

@Hdt80bro Would you be available to make an icon for this upgrade?

@Garanas
Copy link
Member

Garanas commented Aug 14, 2024

I think you're referring to @Fichom , and not hdt80bro. But are these changes approved by the balance team? If so, it is best if @Tagada14 approves the pull request.

@Basilisk3
Copy link
Collaborator Author

I think you're referring to @Fichom , and not hdt80bro. But are these changes approved by the balance team? If so, it is best if @Tagada14 approves the pull request.

The response from the members who replied hasn't been bad on average, so I decided to ask.

On an unrelated note, it would be nice to have some sort of fallback or placeholder for when an upgrade icon is not present. Right now it's a yellow box and I assume mods can have the same problem too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance DO NOT MERGE Don't Merge until removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants