Feature: Sound for match found #3216
Conversation
DotNetSimon
changed the title
|
You can check the default settings by just renaming your client.prefs file |
|
Someone found a nice sound here: #2984 |
- Added tests and fixed existing typo in test.
- Labels
- Labels and checkboxes. Added disabled+Selected 'Display Notification When Match Found' since it should always remain on.
- Add new sound file
Sheikah45
force-pushed
the
feature/sound-for-match-found
branch
from
738cb6c
to
b7a19bd
Compare
|
Right now the tests are failing because the notificationPrefs object wasn't added to the test. Additionally the if check around the playMatchSound is a little redundant since it checks inside the audio service |
I've used this new sound. I think it might be more intrusive/disruptive than the one I was using before but if anyone asks I'll send them to you 👍 |
Fixed both. |
- Removed superfluous check - Added audioService mock to the test, making them pass. - Renamed the preference to be more in line with the existing values.
|
@BlackYps can you try with that sound? It is quite loud and it will scare people shitless when it suddenly blares after 30 minutes of not paying attention :p The sound I used originally is more kind to the ears. https://pixabay.com/sound-effects/countdown-sound-effect-8-bit-151797/ It's Pixabay which we already use. |
|
I've reused the sound from Warren that was lowered by 8db and it's pretty good now. Let me know if there's anything else to adjust @Sheikah45 |
Added a new sound when the match-found notification triggers.
It is like a simple beep-beep-beep-beep race start sound, not too intrusive but clear.
Added notification to enable/disable it (on by default).
Added tests for sound playing as with other sounds.
Manual tests done:
✅ Check labels/checkboxes are ok in English.
✅ Check checkbox functions (on/off)
✅ Check sound plays when match is found
[ ] Check default settings show correctly in settings - notifications window (not sure how to reset settings...)
Not sure how to add all the translations? Used the same words as for the "Match Found" string, so it should be easy to add these.
Fixes #2984