Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2992 Game, map, mod reviews average score filtering #3013

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

bukajsytlos
Copy link
Member

Closes #2992 Game, map, mod reviews average score filtering

@bukajsytlos bukajsytlos force-pushed the feature/#2992-review-score-filtering branch from 798385f to 173c8fc Compare July 18, 2023 09:35
@bukajsytlos bukajsytlos force-pushed the feature/#2992-review-score-filtering branch 3 times, most recently from d4d2f15 to 3302b9c Compare July 18, 2023 10:45
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #3013 (3f24b80) into develop (65fc2f4) will increase coverage by 0.04%.
The diff coverage is 66.03%.

❗ Current head 3f24b80 differs from pull request most recent head 86fea7d. Consider uploading reports for the commit 86fea7d to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3013      +/-   ##
=============================================
+ Coverage      59.31%   59.35%   +0.04%     
- Complexity      4481     4490       +9     
=============================================
  Files            553      553              
  Lines          20119    20156      +37     
  Branches        1040     1040              
=============================================
+ Hits           11933    11964      +31     
- Misses          7639     7645       +6     
  Partials         547      547              
Files Changed Coverage Δ
...aforever/client/vault/search/SearchController.java 54.38% <0.00%> (-0.49%) ⬇️
...om/faforever/client/domain/ReviewsSummaryBean.java 72.97% <40.00%> (-5.16%) ⬇️
...ver/client/replay/OnlineReplayVaultController.java 75.00% <66.66%> (+0.27%) ⬆️
.../faforever/client/query/RangeFilterController.java 78.66% <70.83%> (-2.04%) ⬇️
.../main/java/com/faforever/client/fx/JavaFxUtil.java 62.06% <83.33%> (+1.04%) ⬆️
...a/com/faforever/client/map/MapVaultController.java 67.04% <100.00%> (+0.37%) ⬆️
...a/com/faforever/client/mod/ModVaultController.java 60.00% <100.00%> (+0.54%) ⬆️
...rever/client/query/SearchablePropertyMappings.java 98.21% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fc2f4...86fea7d. Read the comment docs.

@bukajsytlos bukajsytlos force-pushed the feature/#2992-review-score-filtering branch from 3302b9c to 8b21319 Compare July 18, 2023 14:51
@bukajsytlos bukajsytlos force-pushed the feature/#2992-review-score-filtering branch from f5531ca to 4a6ff74 Compare July 18, 2023 19:08
@bukajsytlos bukajsytlos force-pushed the feature/#2992-review-score-filtering branch from 4a6ff74 to b3dc668 Compare July 18, 2023 19:10
@Sheikah45 Sheikah45 merged commit db92c61 into develop Jul 28, 2023
5 checks passed
@Sheikah45 Sheikah45 deleted the feature/#2992-review-score-filtering branch July 28, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game, map, mod reviews average score filtering
2 participants