Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache random faction image #2986

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Cache random faction image #2986

merged 2 commits into from
Jun 10, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #2986 (f495a8f) into develop (bec19fc) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head f495a8f differs from pull request most recent head 8a4d4d5. Consider uploading reports for the commit 8a4d4d5 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2986      +/-   ##
=============================================
- Coverage      61.35%   61.35%   -0.01%     
+ Complexity      4599     4597       -2     
=============================================
  Files            557      557              
  Lines          20191    20192       +1     
  Branches        1048     1048              
=============================================
- Hits           12389    12388       -1     
- Misses          7219     7220       +1     
- Partials         583      584       +1     
Impacted Files Coverage Δ
.../java/com/faforever/client/config/CacheConfig.java 0.00% <0.00%> (ø)
...n/java/com/faforever/client/config/CacheNames.java 0.00% <ø> (ø)
...ain/java/com/faforever/client/theme/UiService.java 0.85% <0.00%> (-0.01%) ⬇️
...om/faforever/client/game/PlayerCardController.java 83.15% <100.00%> (ø)
...com/faforever/client/remote/FafServerAccessor.java 74.81% <100.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec19fc...8a4d4d5. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 329c775 into develop Jun 10, 2023
@Sheikah45 Sheikah45 deleted the maintenance/faction-image branch June 10, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant