Add comment

FAForever · Oct 23, 2023 · 9ef6f6b · 9ef6f6b
1 parent 9ab725e
commit 9ef6f6b
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/src/main/java/com/faforever/client/replay/ReplayDetailController.java b/src/main/java/com/faforever/client/replay/ReplayDetailController.java
@@ -469,23 +469,25 @@ private List<TeamCardController> createTeamCardControllers(Map<String, List<Game
       return controller;
     }).toList();
   }
-  
+
   private GameOutcome calculateGameResult(Map<PlayerBean, GamePlayerStatsBean> statsByPlayer) {
-      Map<GameOutcome, Long> outcomeCounts = statsByPlayer.values()
-          .stream()
-          .map(GamePlayerStatsBean::getResult)
-          .filter(Objects::nonNull)
-          .map(gameOutcome -> (gameOutcome == GameOutcome.CONFLICTING) ? GameOutcome.UNKNOWN : gameOutcome)
-          .map(gameOutcome -> (gameOutcome == GameOutcome.MUTUAL_DRAW) ? GameOutcome.DRAW : gameOutcome)
-          .collect(Collectors.groupingBy(gameOutcome -> gameOutcome, Collectors.counting()));
-
-      if (outcomeCounts.containsKey(GameOutcome.VICTORY)) {
-        return GameOutcome.VICTORY;
-      }
+    // Game outcomes are saved since 2020, so this should suffice for the 
+    // vast majority of replays that people will realistically look up.
+    Map<GameOutcome, Long> outcomeCounts = statsByPlayer.values()
+        .stream()
+        .map(GamePlayerStatsBean::getResult)
+        .filter(Objects::nonNull)
+        .map(gameOutcome -> (gameOutcome == GameOutcome.CONFLICTING) ? GameOutcome.UNKNOWN : gameOutcome)
+        .map(gameOutcome -> (gameOutcome == GameOutcome.MUTUAL_DRAW) ? GameOutcome.DRAW : gameOutcome)
+        .collect(Collectors.groupingBy(gameOutcome -> gameOutcome, Collectors.counting()));
+
+    if (outcomeCounts.containsKey(GameOutcome.VICTORY)) {
+      return GameOutcome.VICTORY;
+    }
 
-      return outcomeCounts.entrySet()
-          .stream()
-          .max(Entry.comparingByValue()).map(Entry::getKey).orElse(GameOutcome.UNKNOWN);
+    return outcomeCounts.entrySet()
+        .stream()
+        .max(Entry.comparingByValue()).map(Entry::getKey).orElse(GameOutcome.UNKNOWN);
   }
 
   private Faction getPlayerFaction(PlayerBean player, Map<PlayerBean, GamePlayerStatsBean> statsByPlayerId) {