Skip to content

Add Open Source Cloud banner to README#477

Open
JuiceAndTheJoe wants to merge 2 commits intoEyevinn:masterfrom
JuiceAndTheJoe:master
Open

Add Open Source Cloud banner to README#477
JuiceAndTheJoe wants to merge 2 commits intoEyevinn:masterfrom
JuiceAndTheJoe:master

Conversation

@JuiceAndTheJoe
Copy link

Summary

  • Adds centered Open Source Cloud banner to README
  • Replaces existing Evaluate badge with new banner format
  • Links to the service's OSC page

Test plan

  • Verify banner renders correctly on GitHub
  • Confirm OSC link is correct

Copy link
Collaborator

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the phrasing is way too general to make it any interesting on this project and is neither good for OSC or for the mp4ff project.

I further tried to use the "service" and didn't understand what to do. Should the command line start with one of the CLI commands, or what?

If that is the case, I think it makes sense to put this section after the CLI commands have been listed and then tell that one can run any of them in OSC.


## Quick Demo: Open Source Cloud

Run this service in the cloud with a single click.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mp4ff is not a service but a library and some tools, so you cannot phrase it like "Run this service in the cloud".

Rephrase it like "Run mp4ff in the cloud with just a click"

---
<div align="center">

## Quick Demo: Open Source Cloud
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be more specific to make it look relevant and not just some arbitrary ad.

Rephrase like "Quick Demo: mp4ff in Open Source Cloud"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants