refactor: move all mp4 test to mp4_test package for black-box testing #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced mp4.AlouBox and mp4.TlouBox with a common mp4.LoudnessBaseBox - mp4.Measurement changed to clearer mp4.LoudnessMeasurement - New Exported constants for ColrBox's ColorType - New mp4.NewFreeBox, mp4.NewSkipBox functions - New mp4.FreeBox.Payload method - New mp4.SencBox methods: SetPerSampleIVSize, PerSampleIVSize, and ReadButNotParsed - New function mp4.CreateUnknownBox - New functions mp4.NewTfrfBox and mp4.NewTfxdBox
tobbee
force-pushed
the
mp4-blackbox-test
branch
from
00aec5f to
b24e7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all tests in the mp4 package were already black-box tests, but not all.
After pondering on Issue #414, I think that it would be useful to make them black-box testing.
That is what this PR does.
A similar approach should be taken to the other repos.
All forks with a different domain, need to make a global replacement of paths in the
_test.gofiles, but that should be relatively easy to automate.During this work, some other changes were needed, or felt natural:
Changed
Added