Skip to content

fix: co64 could use too much memory of the size overflowed 32 bits#405

Merged
tobbee merged 1 commit intoEyevinn:masterfrom
fancybits:fix-co64-size-overflow
Jan 20, 2025
Merged

fix: co64 could use too much memory of the size overflowed 32 bits#405
tobbee merged 1 commit intoEyevinn:masterfrom
fancybits:fix-co64-size-overflow

Conversation

@eric
Copy link
Copy Markdown
Contributor

@eric eric commented Jan 20, 2025

No description provided.

Copy link
Copy Markdown
Collaborator

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty weird case, but surely a possible overflow. Good to have a small piece of data to test it.

@tobbee tobbee merged commit 2330aaa into Eyevinn:master Jan 20, 2025
@eric
Copy link
Copy Markdown
Contributor Author

eric commented Jan 20, 2025

Yep. It took 8 hours of fuzzing to discover it. Looking at the other implementations of expectedSize() it seemed that I had already handled promoting things to uint64 where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants