feat: handle bad descriptors and provide detailed info #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobbee
force-pushed
the
support-bad-descriptors
branch
from
6f97fb4
to
a0f024e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #350, some mp4 samples in the wild have erroneous descriptors.
This PR extends the descriptor handling to become more general, but also to handle
and store data corresponding to bad descriptor data at the end of ES descriptor,
and DecoderConfig descriptor. This makes it possible to Decode and Encode such
assets without change of the data.
The Info() interface as used by mp4ff-info has been extended to reveal more information about encoders.
In particular, a higher level for
esdsboxes propagates into descriptors.This should solve #350 and #348.