Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEKO v0.8.0 #1229

Open
wants to merge 1,003 commits into
base: master
Choose a base branch
from
Open

NEKO v0.8.0 #1229

wants to merge 1,003 commits into from

Conversation

njansson
Copy link
Collaborator

@njansson njansson commented Apr 8, 2024

No description provided.

timfelle and others added 30 commits March 20, 2024 11:24
- Added setup and tear down
- Renamed subroutines to avoid truncation error from Fortran compilers.
Co-authored-by: Tim Felle Olsen <[email protected]>
Co-authored-by: Tim Felle Olsen <[email protected]>
…oller; pass time_step_controller_t to subroutine step() of _scheme_t and their inherit types
@timfelle
Copy link
Collaborator

I guess the new CI is not added in here. Is that the plan?

@njansson
Copy link
Collaborator Author

I guess the new CI is not added in here. Is that the plan?

Good question. I guess it would be rather painful to cherry pick all changes

@timfelle
Copy link
Collaborator

Good question. I guess it would be rather painful to cherry pick all changes

We can also just update the roccm version in a separate PR directly to the release and then wait for 0.8.1 with the CI

@njansson
Copy link
Collaborator Author

Good question. I guess it would be rather painful to cherry pick all changes

We can also just update the roccm version in a separate PR directly to the release and then wait for 0.8.1 with the CI

Sounds like an excellent compromise ;)

@MartinKarp
Copy link
Collaborator

How are we looking on this one? To me it looks good, there are of course things getting added all the time, but I think this is in a relatively good state to get merged and us having a more recent release.

@njansson
Copy link
Collaborator Author

njansson commented Jul 5, 2024

How are we looking on this one? To me it looks good, there are of course things getting added all the time, but I think this is in a relatively good state to get merged and us having a more recent release.

Agree, I think this was also the conclusion at the latest dev meeting.

Let me fix the version number etc , and we focus on 0.9 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants