fix: create-flow scheduling race — AS action never registered#870
Merged
fix: create-flow scheduling race — AS action never registered#870
Conversation
The flow was created with scheduling_config already set (e.g. daily),
then handle_scheduling_update() was called to register the AS action.
But handle_scheduling_update reads the flow back from DB, sees the
interval is already 'daily', and returns early ('nothing changed').
Result: config saved but no AS recurring action created.
Fix: create the flow with interval=manual, then let
handle_scheduling_update() see the change from manual→daily and
properly register the AS action.
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
create-flowsavedscheduling_configto DB first, then calledhandle_scheduling_update(). But that function reads the flow back, sees the interval is already set, and returns early ("nothing changed"). The AS recurring action was never created.Fix
Create the flow with
interval=manual, then lethandle_scheduling_update()see the transition frommanual→dailyand register the AS action.Impact
All 68 venue scraper flows created via
extrachill/add-venuehad no schedule until manually fixed. Closes #869.