feat: getDefaultMaxItems() override point for handler subclasses#845
Merged
feat: getDefaultMaxItems() override point for handler subclasses#845
Conversation
Allows handler subclasses to define their own default max_items instead of the hardcoded 1. Base FetchHandler keeps the conservative default of 1 for AI-heavy pipelines. Event import handlers will override to 0 (unlimited).
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDefaultMaxItems()method toFetchHandler(returns 1) that subclasses can override$config['max_items'] ?? 1with$config['max_items'] ?? $this->getDefaultMaxItems()Why
Event import handlers need unlimited by default (structured data, cheap to process), but RSS/Reddit handlers should keep the safe default of 1. This override point lets each handler family define its own sensible default.
Companion
data-machine-events will override to return 0 (unlimited) in EventImportHandler.