Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any combination of simultaneous sounds #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gstone271
Copy link

Remove the check preventing you from using the "same paw" simultaneously.
There's no particular reason the cat should be allowed to play keyboard 2 and marimba Q at the same time (both are left paw), but not be allowed to play keyboard 1 and marimba Q at the same time. This is especially silly with keyboard 1 and bongo A, which are displayed as different paws, but not allowed to be played simultaneously. This behavior is confusing and unnecessary. Remove this rule so you can play whatever you want.
This also fixes issue #145.
This change has the side effect of letting you play the bongos very fast by using the keyboard and mouse, but that's fine imo.

Remove the check preventing you from using the "same paw" simultaneously.
There's no particular reason the cat should be allowed to play keyboard 2 and marimba Q at the same time (both are left paw), but not be allowed to play keyboard 1 and marimba Q at the same time. This is especially silly with keyboard 1 and bongo A, which are displayed as different paws, but not allowed to be played simultaneously. This behavior is confusing and unnecessary. Remove this rule so you can play whatever you want.
This also fixes issue Externalizable#145.
This change has the side effect of letting you play the bongos very fast by using the keyboard and mouse, but that's fine imo.
@DeannaGelbart
Copy link

Here is another way to do it which doesn't have the side effect of very fast repeats if you hold down a key a little too long

https://github.com/Externalizable/bongo.cat/pull/286/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants