-
Notifications
You must be signed in to change notification settings - Fork 12
Clean up old TRAVIS_* envvars #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fa11fc5
to
a693240
Compare
0fcdd2f
to
1b909ab
Compare
Style issues to be fixed. Otherwise, rest of code looks good to me. Also see Florent's comment on variable naming. |
@inimaga Oddly enough, the CI job isn't actually telling me what style things need fixing. From the output, it looks like it actually passes, then returns a non-0 error code |
e968094
to
b38cbb9
Compare
I really don't know what's going on with the style checker, because it checks clean on my local: vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ vendor/bin/php-cs-fixer check
PHP CS Fixer 3.75.0 Persian Successor by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.3.20
Running analysis on 1 core sequentially.
You can enable parallel runner and speed up the analysis! Please see usage docs for more information.
Loaded config default from "/vagrant/Bedrock-PHP/.php-cs-fixer.php".
Using cache file ".php-cs-fixer.cache".
27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
Found 0 of 27 files that can be fixed in 0.162 seconds, 22.00 MB memory used
vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ echo $?
0 Oh wait, that's CS fixer, not style fixer... |
5ed0c2f
to
1aeb79c
Compare
1aeb79c
to
12a20d3
Compare
This is from the php-style-fixer on local. Not really sure why actions is seeings something different (maybe it's running from the |
c7842d4
to
f4f169e
Compare
We no longer use TravisCI, so these envvars had their values patched over from GITHUB envvars. It makes more sense to use the correct envvars initially.
Part of: https://github.com/Expensify/Expensify/issues/514581#issuecomment-3329458321
Explanation of Change
Mapping:
Related Issues
Deployment