Skip to content

Conversation

twodarek
Copy link

@twodarek twodarek commented Oct 3, 2025

We no longer use TravisCI, so these envvars had their values patched over from GITHUB envvars. It makes more sense to use the correct envvars initially.

Part of: https://github.com/Expensify/Expensify/issues/514581#issuecomment-3329458321

Explanation of Change

Mapping:

TRAVIS_RUNNING - (bool) getenv('GITHUB_SHA'))
TRAVIS_COMMIT - GITHUB_SHA
TRAVIS_BRANCH - GITHUB_REF

Related Issues

Deployment

  • I followed the steps in the README to ensure this PR is deployed properly

@twodarek twodarek requested a review from a team October 3, 2025 16:39
@melvin-bot melvin-bot bot requested review from inimaga and removed request for a team October 3, 2025 16:39
@twodarek twodarek force-pushed the twodarek-cleanup-travis branch from fa11fc5 to a693240 Compare October 3, 2025 17:33
@twodarek twodarek force-pushed the twodarek-cleanup-travis branch from 0fcdd2f to 1b909ab Compare October 3, 2025 17:46
@inimaga
Copy link

inimaga commented Oct 7, 2025

Style issues to be fixed. Otherwise, rest of code looks good to me. Also see Florent's comment on variable naming.

@twodarek
Copy link
Author

twodarek commented Oct 7, 2025

Style issues to be fixed

@inimaga Oddly enough, the CI job isn't actually telling me what style things need fixing. From the output, it looks like it actually passes, then returns a non-0 error code

@twodarek twodarek force-pushed the twodarek-cleanup-travis branch from e968094 to b38cbb9 Compare October 7, 2025 22:43
@twodarek
Copy link
Author

twodarek commented Oct 7, 2025

I really don't know what's going on with the style checker, because it checks clean on my local:

vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ vendor/bin/php-cs-fixer check
PHP CS Fixer 3.75.0 Persian Successor by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.3.20
Running analysis on 1 core sequentially.
You can enable parallel runner and speed up the analysis! Please see usage docs for more information.
Loaded config default from "/vagrant/Bedrock-PHP/.php-cs-fixer.php".
Using cache file ".php-cs-fixer.cache".
 27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


Found 0 of 27 files that can be fixed in 0.162 seconds, 22.00 MB memory used
vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ echo $?
0

Oh wait, that's CS fixer, not style fixer...

@twodarek twodarek force-pushed the twodarek-cleanup-travis branch 2 times, most recently from 5ed0c2f to 1aeb79c Compare October 8, 2025 19:25
@twodarek twodarek force-pushed the twodarek-cleanup-travis branch from 1aeb79c to 12a20d3 Compare October 8, 2025 19:26
@twodarek
Copy link
Author

twodarek commented Oct 8, 2025

vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ ./ci/php-style-fixer check
PHP CS Fixer 3.75.0 Persian Successor by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.3.20
Running analysis on 1 core sequentially.
You can enable parallel runner and speed up the analysis! Please see usage docs for more information.
Loaded config default from "/vagrant/Bedrock-PHP/.php-cs-fixer.php".
 27/27 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


Found 0 of 27 files that can be fixed in 0.394 seconds, 22.00 MB memory used
vagrant@expensidev-2404:/vagrant/Bedrock-PHP$ echo $?
0

This is from the php-style-fixer on local. Not really sure why actions is seeings something different (maybe it's running from the main branch?)

@twodarek twodarek force-pushed the twodarek-cleanup-travis branch from c7842d4 to f4f169e Compare October 9, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants