Phase2 sub3 fix feedback - #97757
Draft
hoangzinh wants to merge 3 commits into
Draft
Conversation
…ame across libs Migrate call sites off deprecatedGetReportName to the new getReportName signature, which takes the precomputed report name string directly instead of the full reportAttributes map.
- Replace `reportAttributes` params with a single report-name arg in getMovedTransactionMessage, getUnreportedTransactionMessage, getShareDestination and getMovedFromOrToReportMessage - Add getMovedTransactionReportID/getUnreportedTransactionReportID so components can subscribe via useDerivedReportNameByReportID instead of the whole report attributes map - Fall back to module-level reportAttributesDerivedValue for imperative callers (SidebarUtils, OptionsListUtils, ReportNameUtils, ContextMenu) - Drop reportAttributes from ContextMenuActionPayload and getReportPreviewMessageForCopy
Contributor
Author
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated and applied the same principle across the rest of the commit.
getShareDestinationnow takesreportName?: string, andDynamicNewTaskPagesources it via the existinguseDerivedReportNameByReportIDselector instead of subscribing to the whole map.getMovedTransactionMessage/getUnreportedTransactionMessagegot the same change (derivedReportName?: string). These were the worst case —MovedTransactionAction/UnreportedTransactionActionare report-action list items, so every instance in a chat held the full map. Since the report they name is resolved internally from the action, I exportedgetMovedTransactionReportID/getUnreportedTransactionReportIDso callers can key the selector without duplicating that logic