Fix Getting started "Talk to Concierge" link font size (15px → 13px) - #97714
Fix Getting started "Talk to Concierge" link font size (15px → 13px)#97714MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
|
@MelvinBot please fill out the PR author checklist as best you can and mark this ready for review. |
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Filled out the PR Author Checklist as best I could and marked this Ready for review. Also added the What I checked off — everything I can stand behind for this static, one-line style change: the linked issue, the Tests / Offline / QA steps, code-pattern/review-guideline items, and the conditional blocks that don't apply here (no new CSS style, no new assets, no generic-component/Storybook/deeplink/messaging impact). Left unchecked (honesty over completeness):
The change itself is straightforward and correct by inspection: the nested link Reviewer to-do: grab the MacOS: Chrome / Safari screenshot from an account that shows the Getting started card and confirm the link now matches the surrounding 13px text with no console errors. |
|
I looked into the failing checks — there's nothing to fix in the code. ✅ Every substantive check passes: ESLint, typecheck, all 8 test jobs, the builds, perf tests, Storybook, and spellcheck are all green. The single red check is PR Author Checklist / checklist, which isn't a code failure. It fails because the author checklist in the PR description still has unticked boxes:
This is a manual verification step that only a person can clear — I can't push a commit to satisfy it. To turn it green, |
|
I re-checked — the state is unchanged and there's still no code fix to make. ✅ 38 checks pass, 0 substantive failures. ESLint, typecheck, all 8 test jobs, builds, perf tests, Storybook, and spellcheck are green. The one red check is PR Author Checklist / checklist, which isn't a code failure:
I can't clear this by pushing a commit — it's a manual step that only a person can complete. To make it green, |
|
@shubham1206agra please do final review and add screenshots when you can, thanks! |
|
All checks on this PR are now passing ✅ — 39 green, 4 skipped, nothing failing or pending. The only check that was previously red was PR Author Checklist / checklist, which is a manual verification step (it fails while the author checklist boxes are unticked, not because of any code problem). That has since cleared, so there's no code fix to push. |
|
All checks are green now — there's nothing left to fix. ✅ Every check on this PR is passing, including PR Author Checklist / checklist, which had been the only red one earlier (it failed because the author checklist boxes in the description were unticked — a manual step, not a code issue). Those boxes are now checked, so that check re-ran and passed. 39 passing, 4 skipped, 0 failing. Good to go. |
Reviewer Checklist
Screenshots/Videos
|
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #97713 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |


Explanation of Change
The "Talk to Concierge" link in the Getting started card rendered at 15px while the text around it is 13px.
The link was a nested
Textstyled only withstyles.link, which does not set afontSize. Expensify'sTextcomponent defaultsfontSizetovariables.fontSizeNormal(15px) whenever the passed style doesn't override it, so the nested link fell back to 15px even though its parentTextusesstyles.textLabelSupporting(13px).This composes
styles.textLabelSupportingwithstyles.linkon the nestedTextso the link inherits the 13px label size while keeping the link color (styles.linkis spread last, so its color still wins). The link now matches the surrounding text.Fixed Issues
$ #97713
PROPOSAL:
Tests
Offline tests
Same as tests (this is a static styling change, unaffected by network state).
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari