Skip to content

Fix Getting started "Talk to Concierge" link font size (15px → 13px) - #97714

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-gettingStartedConciergeLinkFontSize
Open

Fix Getting started "Talk to Concierge" link font size (15px → 13px)#97714
MelvinBot wants to merge 1 commit into
mainfrom
claude-gettingStartedConciergeLinkFontSize

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The "Talk to Concierge" link in the Getting started card rendered at 15px while the text around it is 13px.

The link was a nested Text styled only with styles.link, which does not set a fontSize. Expensify's Text component defaults fontSize to variables.fontSizeNormal (15px) whenever the passed style doesn't override it, so the nested link fell back to 15px even though its parent Text uses styles.textLabelSupporting (13px).

This composes styles.textLabelSupporting with styles.link on the nested Text so the link inherits the 13px label size while keeping the link color (styles.link is spread last, so its color still wins). The link now matches the surrounding text.

Fixed Issues

$ #97713
PROPOSAL:

Tests

  1. Open the app on an account that shows the Getting started card on the home page.
  2. Locate the footer help line "Need help getting set up? Talk to Concierge for a guided setup."
  3. Verify the "Talk to Concierge" link is the same font size (13px) as the surrounding text, not larger.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests (this is a static styling change, unaffected by network state).

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@shawnborton

Copy link
Copy Markdown
Contributor

@MelvinBot please fill out the PR author checklist as best you can and mark this ready for review.

@melvin-bot
melvin-bot Bot requested a review from shawnborton August 3, 2026 17:47
@MelvinBot
MelvinBot marked this pull request as ready for review August 3, 2026 17:48
@MelvinBot
MelvinBot requested a review from a team as a code owner August 3, 2026 17:48
@melvin-bot
melvin-bot Bot requested review from shubham1206agra and removed request for a team August 3, 2026 17:48
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team August 3, 2026 17:48
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Filled out the PR Author Checklist as best I could and marked this Ready for review. Also added the Design label since this is a UI sizing change.

What I checked off — everything I can stand behind for this static, one-line style change: the linked issue, the Tests / Offline / QA steps, code-pattern/review-guideline items, and the conditional blocks that don't apply here (no new CSS style, no new assets, no generic-component/Storybook/deeplink/messaging impact).

Left unchecked (honesty over completeness):

  • Cross-platform testing & screenshots and "no console errors" — I couldn't verify these at runtime. The Getting started card doesn't render on the CI test account (onboarding is skipped there), so the "Talk to Concierge" footer line never appears to screenshot or inspect. These need a human tester on an account that shows the card.
  • Failure scenarios / offline network toggle / high-traffic account — not applicable to a pure styling change and not something I ran.
  • Unit tests — none added; a font-size composition like this isn't a good unit-test target.

The change itself is straightforward and correct by inspection: the nested link Text was styled only with styles.link (no fontSize, so it fell back to the Text default of 15px). Composing [styles.textLabelSupporting, styles.link] makes it inherit the 13px label size while styles.link (spread last) keeps the link color.

Reviewer to-do: grab the MacOS: Chrome / Safari screenshot from an account that shows the Getting started card and confirm the link now matches the surrounding 13px text with no console errors.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the failing checks — there's nothing to fix in the code. ✅

Every substantive check passes: ESLint, typecheck, all 8 test jobs, the builds, perf tests, Storybook, and spellcheck are all green.

The single red check is PR Author Checklist / checklist, which isn't a code failure. It fails because the author checklist in the PR description still has unticked boxes:

You completed 25 out of 38 checklist items with 13 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

This is a manual verification step that only a person can clear — I can't push a commit to satisfy it. To turn it green, shawnborton (or a reviewer) just needs to review and tick the remaining boxes in the PR Author Checklist section above. Once they're checked, this check re-runs and passes.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I re-checked — the state is unchanged and there's still no code fix to make. ✅

38 checks pass, 0 substantive failures. ESLint, typecheck, all 8 test jobs, builds, perf tests, Storybook, and spellcheck are green.

The one red check is PR Author Checklist / checklist, which isn't a code failure:

You completed 25 out of 38 checklist items with 13 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

I can't clear this by pushing a commit — it's a manual step that only a person can complete. To make it green, shawnborton or a reviewer needs to tick the remaining 13 boxes in the PR Author Checklist section of the PR description, and the check will re-run and pass.

@shawnborton

Copy link
Copy Markdown
Contributor

@shubham1206agra please do final review and add screenshots when you can, thanks!

@MelvinBot

Copy link
Copy Markdown
Contributor Author

All checks on this PR are now passing ✅ — 39 green, 4 skipped, nothing failing or pending.

The only check that was previously red was PR Author Checklist / checklist, which is a manual verification step (it fails while the author checklist boxes are unticked, not because of any code problem). That has since cleared, so there's no code fix to push.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

All checks are green now — there's nothing left to fix. ✅

Every check on this PR is passing, including PR Author Checklist / checklist, which had been the only red one earlier (it failed because the author checklist boxes in the description were unticked — a manual step, not a code issue). Those boxes are now checked, so that check re-ran and passed.

39 passing, 4 skipped, 0 failing. Good to go.

@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screenshot 2026-08-04 at 8 24 28 AM Screenshot 2026-08-04 at 8 32 21 AM

@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #97713 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from marcochavezf August 4, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants