Skip to content

Fix search bar not hiding when member count drops below 12 offline #91513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinBot wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −1
Open

Fix search bar not hiding when member count drops below 12 offline #91513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf5e422
Fix search bar not hiding when member count drops below threshold off…
MelvinBot May 23, 2026
1691e2f
Merge remote-tracking branch 'origin/main' into claude-searchBarOffli…
MelvinBot May 23, 2026
4383668
Merge remote-tracking branch 'origin/main' into claude-searchBarOffli…
MelvinBot May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/pages/workspace/WorkspaceMembersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,14 @@ function WorkspaceMembersPage({personalDetails, route, policy}: WorkspaceMembers
(isMergeHRSyncInProgress || (connectionSyncProgress?.connectionName === connectedHRProvider?.connectionName && isConnectionInProgress(connectionSyncProgress, policy)));
const isPendingAddOrDelete =
isOffline && data?.some((member) => member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD);
const shouldShowSearchBar = data.length >= CONST.STANDARD_LIST_ITEM_LIMIT;
const shouldShowSearchBar = memberCount >= CONST.STANDARD_LIST_ITEM_LIMIT;
const prevMemberCount = usePrevious(memberCount);
useEffect(() => {
if (prevMemberCount < CONST.STANDARD_LIST_ITEM_LIMIT || memberCount >= CONST.STANDARD_LIST_ITEM_LIMIT) {
return;
}
setInputValue('');
}, [memberCount, prevMemberCount, setInputValue]);
const debouncedFilteredData = useDebouncedValue(filteredData, CONST.TIMING.SEARCH_OPTION_LIST_DEBOUNCE_TIME);
const isFilteringMembers = filteredData?.length < debouncedFilteredData?.length;
const displayedFilteredData = isFilteringMembers ? debouncedFilteredData : filteredData;
Expand Down
Loading