Update duplicate RHP screen to match other flows#91496
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Root cause of #91377 problem :The root cause is that in More specifically:
That selection UI was then rendered through:
which meant the radio buttons were still shown even when they no longer had a valid related action. Solution :Based on the follow-up direction in this comment, the paid/approved case should switch to a simplified single-action state. The changes are:
This keeps the normal duplicate-selection flow unchanged when selection is valid, while making the paid/approved case match the expected behavior from the issue discussion. Demo: Screen.Recording.2026-05-23.at.1.17.23.PM.mov |
melvin-bot
Bot
requested review from
JmillsExpensify and
sobitneupane
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d510eb9b1d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <PressableWithFeedback | ||
| sentryLabel={CONST.SENTRY_LABEL.SEARCH.TRANSACTION_LIST_ITEM} | ||
| onPress={handlePreviewPress} | ||
| accessibilityLabel={transaction.comment?.comment ?? ''} |
There was a problem hiding this comment.
The row-level PressableWithFeedback always calls handlePreviewPress, but the new radio selector lives inside this same pressable and there is no propagation guard, so clicking the radio can also fire the parent press handler. In web/mWeb this means choosing a duplicate immediately navigates into the transaction preview instead of just selecting it, which breaks the new “Keep selected” flow unless users avoid the radio input. Please stop the radio interaction from bubbling to the parent press action.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed. I stopped the duplicate-review radio interaction from bubbling to the row press, so selecting a radio no longer opens the preview.
1 participant
Explanation of Change
This PR refreshes the first screen of the “Review duplicates” flow so it matches the newer compact expense review patterns used elsewhere in the app. Duplicate expenses are now shown as concise selectable rows instead of large preview cards, while still letting users open each expense for full details. The screen keeps the existing product behavior: users can either keep all duplicates or select one expense to continue through the current review flow.
Fixed Issues
$ #88342
PROPOSAL: #88342 (comment)
Tests
Create four expenses with the same amount, each using a different merchant category and unique tags.
Open the expense report containing those expenses.
Click “Review duplicates.”
Verify that the RHP panel displays compact duplicate expense cards for all four expenses created in Step 1.
Verify that each duplicate card displays the following details:
Verify that each duplicate card includes a selection control (radio button).
Verify that the bottom of the panel displays the following action buttons:
Select one of the duplicate expenses.
Click “Keep selected.”
Continue through the duplicate resolution flow by selecting which fields to keep (for example: category, tags, and other available attributes).
Verify that the selected expense is retained and the remaining duplicate expenses are resolved according to the chosen options.
Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Recording_20260512_191611.mp4
Android: mWeb Chrome
Recording_20260512_193837.mp4
iOS: Native
Screen.Recording.2026-05-12.at.6.39.27.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-12.at.6.43.37.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-12.at.6.20.35.PM.mov