[NO QA] feat: introduce ExportDownloadStatusModal #91490
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| import {hasSeenTourSelector} from '@selectors/Onboarding'; | ||
| import React, {useCallback, useEffect} from 'react'; | ||
| import {View} from 'react-native'; | ||
| import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import usePreviousDefined from '@hooks/usePreviousDefined'; | ||
| import useResponsiveLayout from '@hooks/useResponsiveLayout'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import fileDownload from '@libs/fileDownload'; | ||
| import {clearExportDownload, sendExportFileFromConcierge} from '@userActions/Export'; | ||
| import {navigateToConciergeChat} from '@userActions/Report'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import ActivityIndicator from './ActivityIndicator'; | ||
| import Button from './Button'; | ||
| import Modal from './Modal'; | ||
| import Text from './Text'; | ||
|
|
||
| type ExportDownloadStatusModalProps = { | ||
| /** The export ID to subscribe to */ | ||
| exportID: string; | ||
|
|
||
| /** Whether the modal is visible */ | ||
| isVisible: boolean; | ||
|
|
||
| /** Callback when the modal is closed */ | ||
| onClose: () => void; | ||
|
|
||
| /** Body text for the failed state — PDF and CSV use different copy */ | ||
| failedBody?: string; | ||
| }; | ||
|
|
||
| function ExportDownloadStatusModal({exportID, isVisible, onClose, failedBody}: ExportDownloadStatusModalProps) { | ||
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
| // isSmallScreenWidth is needed here because the modal type depends on actual screen width, not layout mode | ||
| // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth | ||
| const {isSmallScreenWidth} = useResponsiveLayout(); | ||
| const {accountID: currentUserAccountID} = useCurrentUserPersonalDetails(); | ||
|
Contributor
There was a problem hiding this comment. ❌ CONSISTENCY-5 (docs)The Add a justification comment explaining why // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
// isSmallScreenWidth is needed here because the modal type depends on actual screen width, not layout mode
const {isSmallScreenWidth} = useResponsiveLayout();Reviewed at: 2a94a51 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency. |
||
|
|
||
| const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID); | ||
| const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED); | ||
| const [betas] = useOnyx(ONYXKEYS.BETAS); | ||
| const [isSelfTourViewed] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector}); | ||
|
|
||
| const [exportDownload] = useOnyx(`${ONYXKEYS.COLLECTION.EXPORT_DOWNLOAD}${exportID}`); | ||
| const displayedExport = usePreviousDefined(exportDownload); | ||
|
|
||
| const state = displayedExport?.state; | ||
| const shouldSendFromConcierge = displayedExport?.shouldSendFromConcierge; | ||
| const downloadURL = displayedExport?.downloadURL; | ||
| const isPreparing = state === CONST.EXPORT_DOWNLOAD.STATE.PREPARING && !shouldSendFromConcierge; | ||
| const isConcierge = !!shouldSendFromConcierge; | ||
| const isReady = state === CONST.EXPORT_DOWNLOAD.STATE.READY; | ||
| const isFailed = state === CONST.EXPORT_DOWNLOAD.STATE.FAILED; | ||
|
|
||
| useEffect(() => { | ||
| if (!isReady || !downloadURL || shouldSendFromConcierge) { | ||
| return; | ||
| } | ||
| fileDownload(translate, downloadURL); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isReady]); | ||
|
There was a problem hiding this comment.
The auto-download effect reads Useful? React with 👍 / 👎. |
||
|
|
||
| const handleSendFromConcierge = useCallback(() => { | ||
| sendExportFileFromConcierge(exportID, displayedExport ?? undefined); | ||
| }, [exportID, displayedExport]); | ||
|
|
||
| const handleGoToConcierge = useCallback(() => { | ||
| onClose(); | ||
| navigateToConciergeChat(conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas); | ||
| }, [onClose, conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas]); | ||
|
|
||
| const handleDismiss = useCallback(() => { | ||
| onClose(); | ||
| }, [onClose]); | ||
|
|
||
| const handleDownloadFile = useCallback(() => { | ||
| if (!downloadURL) { | ||
| return; | ||
| } | ||
| fileDownload(translate, downloadURL); | ||
| }, [downloadURL, translate]); | ||
|
|
||
| const handleClose = useCallback(() => { | ||
| clearExportDownload(exportID, displayedExport ?? undefined); | ||
| onClose(); | ||
| }, [exportID, displayedExport, onClose]); | ||
|
|
||
| const isNonDismissible = isPreparing; | ||
|
|
||
| const renderContent = () => { | ||
| if (isPreparing) { | ||
| return ( | ||
| <> | ||
| <ActivityIndicator | ||
| size="large" | ||
| style={styles.mb4} | ||
| reasonAttributes={{context: 'ExportDownloadStatusModal.preparing'}} | ||
| /> | ||
| <Text style={[styles.textHeadlineH1, styles.textAlignCenter, styles.mb2]}>{translate('exportDownload.preparingTitle')}</Text> | ||
| <Text style={[styles.textAlignCenter, styles.mb5]}>{translate('exportDownload.preparingBody')}</Text> | ||
| <Button | ||
| success | ||
| text={translate('exportDownload.sendFromConcierge')} | ||
| onPress={handleSendFromConcierge} | ||
| style={styles.w100} | ||
| /> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| if (isConcierge) { | ||
| return ( | ||
| <> | ||
| <Text style={[styles.textHeadlineH1, styles.textAlignCenter, styles.mb2]}>{translate('exportDownload.conciergeTitle')}</Text> | ||
| <Text style={[styles.textAlignCenter, styles.mb5]}>{translate('exportDownload.conciergeBody')}</Text> | ||
| <Button | ||
| success | ||
| text={translate('exportDownload.goToConcierge')} | ||
| onPress={handleGoToConcierge} | ||
| style={styles.w100} | ||
| /> | ||
| <Button | ||
| text={translate('exportDownload.dismiss')} | ||
| onPress={handleDismiss} | ||
|
Contributor
There was a problem hiding this comment. I think we only need to call the |
||
| style={[styles.w100, styles.mt3]} | ||
| /> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| if (isReady) { | ||
| return ( | ||
| <> | ||
| <Text style={[styles.textHeadlineH1, styles.textAlignCenter, styles.mb2]}>{translate('exportDownload.readyTitle')}</Text> | ||
| <Text style={[styles.textAlignCenter, styles.mb5]}>{translate('exportDownload.readyBody')}</Text> | ||
| <Button | ||
| success | ||
| text={translate('exportDownload.downloadFile')} | ||
| onPress={handleDownloadFile} | ||
| style={styles.w100} | ||
| /> | ||
| <Button | ||
| text={translate('exportDownload.close')} | ||
| onPress={handleClose} | ||
| style={[styles.w100, styles.mt3]} | ||
| /> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| if (isFailed) { | ||
| return ( | ||
| <> | ||
| <Text style={[styles.textHeadlineH1, styles.textAlignCenter, styles.mb2]}>{translate('exportDownload.failedTitle')}</Text> | ||
| {!!failedBody && <Text style={[styles.textAlignCenter, styles.mb5]}>{failedBody}</Text>} | ||
| <Button | ||
| text={translate('exportDownload.close')} | ||
| onPress={handleClose} | ||
| style={styles.w100} | ||
| /> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| return null; | ||
| }; | ||
|
|
||
| return ( | ||
| <Modal | ||
| isVisible={isVisible} | ||
| onClose={isNonDismissible ? () => {} : onClose} | ||
| onBackdropPress={isNonDismissible ? () => {} : undefined} | ||
| type={isSmallScreenWidth ? CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED : CONST.MODAL.MODAL_TYPE.CONFIRM} | ||
| innerContainerStyle={styles.pv0} | ||
| > | ||
| <View style={[styles.m5, styles.alignItemsCenter]}>{renderContent()}</View> | ||
| </Modal> | ||
| ); | ||
| } | ||
|
|
||
| ExportDownloadStatusModal.displayName = 'ExportDownloadStatusModal'; | ||
|
|
||
| export default ExportDownloadStatusModal; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use the
useCallBackin any new component because the component must compile with React Compiler, quote from here