Skip to content

[No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer#90568

Open
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docsUpdatesForPR76741
Open

[No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer#90568
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docsUpdatesForPR76741

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates the "Edit or Delete Messages" section in Chat-Features-and-Moderation-Tools.md to reflect the new editing behavior introduced in New editing mechanism for small screens #76741
  • On mobile/small screens, editing now uses the bottom composer instead of inline editing
  • Separates desktop and mobile instructions per HelpDot naming conventions (platform-specific flows must be documented separately)

Test plan

  • Verify the updated article renders correctly on the help site
  • Confirm desktop editing steps match current desktop behavior (inline editing)
  • Confirm mobile editing steps match the new bottom-composer behavior

Co-authored-by: Alexey Kureev <Kureev@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 13, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#76741 Update message editing steps for mobile composer [No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer May 13, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://be44ce95.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott marked this pull request as ready for review May 15, 2026 02:13
@stephanieelliott stephanieelliott self-requested a review as a code owner May 15, 2026 02:13
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the "Edit or Delete Messages" section in Chat-Features-and-Moderation-Tools.md to separate desktop and mobile instructions, reflecting a behavioral difference where mobile editing now uses the bottom composer instead of inline editing. The change is well-motivated and improves cross-platform clarity. There are a few governance compliance items to address.

Scores Summary

  • Readability: 8/10 - Steps are clear, sequential, and action-oriented. The desktop/mobile split improves scannability. Minor deduction: "the message text appears in the composer at the bottom of the screen" in mobile step 4 is slightly verbose and could be tightened.
  • AI Readiness: 6/10 - The new ## headings are task-based and include "How to," which is good. However, per HELP_AUTHORING_GUIDELINES.md Section 2, headings should not use platform-only labels as differentiators. The headings "How to edit or delete a message on desktop" and "How to edit or delete a message on mobile" use platform labels rather than the exact feature name. They should include the feature context (e.g., "How to edit or delete a chat message on desktop" or similar phrasing that includes the feature name). Additionally, the parent # Edit or Delete Messages heading is not task-based (it is a noun/action phrase without a verb-first or question-word-first structure), though this is pre-existing and not introduced by this PR.
  • Style Compliance: 8/10 - Button names (Edit comment, Delete comment, Enter, Save) are correctly bolded. The desktop/mobile separation follows the Navigation Instruction Standards in HELPSITE_NAMING_CONVENTIONS.md ("If Web and Mobile Navigation Differ: Provide separate instructions"). Minor note: the governance docs use "Web" and "Mobile" as platform labels, while the PR uses "desktop" and "mobile" -- this is acceptable but worth noting for consistency across articles.

Key Findings

  • Positive: Splitting desktop and mobile instructions is the right call per governance rules, since the editing behavior genuinely differs between platforms (inline vs. composer).
  • Positive: Steps are sequential, action-oriented, and aligned with actual UI flow per Section 5 of the authoring guidelines.
  • Improvement needed: The ## headings should ideally include the feature name for better AI retrieval precision (e.g., "How to edit or delete a chat message on desktop" rather than "How to edit or delete a message on desktop").
  • Pre-existing issue (not scored against this PR): The parent # Edit or Delete Messages heading is not task-based per Section 2 rules. The article also lacks an internalScope field in its YAML frontmatter, which is required per Section 3 of the authoring guidelines. These are outside the scope of this PR but worth noting for a future pass.

Recommendations

  1. Consider adding "chat" to the ## headings to include the feature name (e.g., "How to edit or delete a chat message on desktop") for improved search and retrieval precision.
  2. The changes are otherwise solid and align well with governance expectations for cross-platform documentation.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md - Desktop/mobile instruction split for message editing. Good structural change with minor heading refinement opportunity.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

# Edit or Delete Messages

**To edit or delete a message:**
## How to edit or delete a message on desktop
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming convention: The governance docs (HELPSITE_NAMING_CONVENTIONS.md, Navigation Instruction Standards) consistently use "web" and "mobile" as the platform labels — not "desktop." Consider changing this to ## How to edit or delete a message on web for consistency with Expensify's standard platform terminology.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79d533184d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

1. Open a chat.
2. Long-press a message.
3. Select **Edit comment** or **Delete comment**.
4. If editing, the message text appears in the composer at the bottom of the screen. Update the text and tap **Save**.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't document reverted mobile composer behavior

This step now tells mobile users that edits move to the bottom composer, but in the parent of this docs commit the composer-editing change has already been reverted (#90513): ChatMessageContent still replaces the message with ReportActionItemMessageEdit, and that component renders the edit Composer inline inside the report action rather than in the bottom composer. Publishing this HelpDot article would give mobile users the wrong place to look when they choose Edit comment.

Useful? React with 👍 / 👎.

@stephanieelliott stephanieelliott self-assigned this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants