Allow $0 as valid card limit when editing Expensify Card#90540
Open
MelvinBot wants to merge 1 commit into
Open
Allow $0 as valid card limit when editing Expensify Card#90540MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
The validation in DynamicExpensifyCardLimitPage used !Number(values.limit)
to check for invalid amounts. Since Number('0') is 0 and !0 is true,
a $0 limit was always rejected as invalid. This prevented editing cards
whose limit was set to $0 in Expensify Classic.
Changed the check to Number.isNaN(Number(values.limit)) which correctly
allows 0 while still rejecting non-numeric input.
Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
7 tasks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
grgia
approved these changes
May 14, 2026
Contributor
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Screen.Recording.2026-05-14.at.4.38.17.PM.mov
The validation in
DynamicExpensifyCardLimitPageused!Number(values.limit)to check for invalid amounts. SinceNumber('0')evaluates to0which is falsy, a $0 card limit was always rejected as "invalid amount". This prevented admins from editing cards whose limit was set to $0 in Expensify Classic (OldDot).Changed the check to
Number.isNaN(Number(values.limit))which correctly allows 0 as a valid limit while still rejecting non-numeric input. Empty input is already handled bygetFieldRequiredErrors.Fixed Issues
$ #90487
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — validation is purely client-side with no network dependency.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari