[No QA] Lydia update unreported flow#90535
Conversation
Updated the guide on managing expenses in reports to provide clearer instructions on adding, deleting, and editing expenses, as well as collaboration features.
Updated references from 'Expensify' to 'New Expensify' and made minor adjustments for clarity.
Updated content for clarity and consistency throughout the Spend page guide, including rephrasing sentences and adjusting formatting for better readability.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
| - Once added, the **Submit** button appears in the header (replacing **Add expense**, which moves to the **More** menu). | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Heading violation: # Filters is a noun-only heading and also uses a # level (only one # heading is allowed per article, plus # FAQ). Per HELP_AUTHORING_GUIDELINES.md Section 2, all headings must be task-based and start with an action verb or question word. Per Section 4, content sections must use ##.
Suggested fix: ## How to use filters to find reports and expenses
There was a problem hiding this comment.
@stephanieelliott this heading change was authored by the SDO when I originally drafted these. Have guidelines since changed or is GH off the beam here?
There was a problem hiding this comment.
Yeah only one # is allowed per article, and they must be task-based ("how to", "who can") - this is for AZ retrieval. So I would go with the bot's suggestion in this case!
| **Note**: If no filters are applied, the page defaults to showing your most recent unreported expenses. | ||
|
|
||
| --- | ||
|
|
There was a problem hiding this comment.
Heading violation: # Smart Suggestions is a noun-only heading and also uses a # level (only one # heading is allowed per article, plus # FAQ). Per HELP_AUTHORING_GUIDELINES.md Sections 2 and 4, headings must be task-based and content sections must use ##.
Suggested fix: ## How to use Smart Suggestions
|
|
||
| Smart suggestions recommend the next best action—like submitting a report or adding unreported expenses—based on your activity. | ||
| Smart suggestions recommend the next best action based on your activity. | ||
|
|
There was a problem hiding this comment.
Heading violation: ## Where they appear does not include the feature name and uses a vague pronoun. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be explicit, feature-specific, and searchable.
Suggested fix: ## Where Smart Suggestions appear
| - **SelfDM**: Suggests unreported expenses to add to a report. | ||
| - **Empty draft reports**: Prompts you to add recent unreported expenses. | ||
| - **Global create/quick actions**: Suggests creating a report if you frequently submit grouped expenses | ||
|
|
There was a problem hiding this comment.
Heading violation: ## Benefits is a generic, noun-only heading. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be task-based and start with an action verb or question word. Generic headings like "Benefits" are forbidden.
Suggested fix: Merge this content into the parent Smart Suggestions section, or use a heading like ## How Smart Suggestions help you report faster.
| **Note:** The bulk action menu appears after selecting at least one expense. | ||
|
|
||
| ## Steps to Move Expenses Between Reports | ||
| ## Moving Expenses Between Reports |
There was a problem hiding this comment.
Heading violation: ## Moving Expenses Between Reports uses a gerund rather than starting with an action verb or question word. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be task-based.
Suggested fix: ## How to move expenses between reports
There was a problem hiding this comment.
@stephanieelliott same question here: this was also authored by the SDO originally. Have guidelines since changed or is GH off the beam here too?
There was a problem hiding this comment.
Yes this a another one where I would accept the bot's suggestion - the headings should be task-based!
| - The expense appears in the table | ||
| - Its row is briefly highlighted as new | ||
| - Once added, the **Submit** button appears in the header (replacing **Add expense**, which moves to the **More** menu) | ||
| ## Adding a New Expense to the Table |
There was a problem hiding this comment.
Heading violation: ## Adding a New Expense to the Table uses a gerund rather than starting with an action verb or question word. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be task-based.
Suggested fix: ## How to add a new expense to the table
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@twisterdotcom Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates three articles in the reports-and-expenses section: Getting-Started-with-the-Spend-Page, Managing-Expenses-in-a-Report, and Track-Expenses. The changes improve sentence clarity, add punctuation consistency (trailing periods on list items), and introduce useful content (Tags column, Comments and Collaboration section, expanded tracked-expense options). However, several proposed heading changes move away from governance compliance rather than toward it, and metadata gaps remain unaddressed. Scores Summary
Key FindingsHeading Regressions (HELP_AUTHORING_GUIDELINES.md Section 2)
Multiple # Headings (HELP_AUTHORING_GUIDELINES.md Section 4) Missing internalScope Metadata (HELP_AUTHORING_GUIDELINES.md Section 3) Three Dots Menu Violations (HELPSITE_NAMING_CONVENTIONS.md) Full URL Instead of Relative Link (HELP_AUTHORING_GUIDELINES.md Section 7) Positive Aspects
Track-Expenses Step Numbering Recommendations
Files Reviewed
Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md. |
| --- | ||
|
|
||
| ## How to View and Use the Expense Table | ||
| ## Understanding the Expense Table |
There was a problem hiding this comment.
Heading violation: ## Understanding the Expense Table uses a gerund rather than starting with an action verb or question word. Per HELP_AUTHORING_GUIDELINES.md Section 2, all ## headings must be task-based.
The previous heading ## How to View and Use the Expense Table was already compliant. Consider keeping it, or use something like ## How to view and use the expense table.
| Additional columns such as **Attendees** and **Per attendee** can be enabled via the **Columns** picker when attendee tracking is available. | ||
|
|
||
| Clicking a row opens the full expense in a side panel (web) or details screen (mobile). | ||
| Clicking a row opens the full expense details in a side panel (web) or details screen (mobile). |
There was a problem hiding this comment.
Heading violation: ## Comments and Collaboration is a noun-only heading. Per HELP_AUTHORING_GUIDELINES.md Section 2, all headings must be task-based and start with an action verb or question word. Noun-only or topic-only headings are explicitly forbidden.
Suggested fix: ## How to use comments and collaboration on a report
|
|
||
| 1. (Admins only) Open the report. | ||
| 2. Click **More > Cancel Payment** if Paid. | ||
| 2. Click **More > Cancel Payment** (if Paid). |
There was a problem hiding this comment.
Naming convention violation: Per HELPSITE_NAMING_CONVENTIONS.md, the three dots menu must never be called "More" or "More menu." The required format is: Select the three dots **(⋮)**.
Suggested fix: 2. Select the three dots **(⋮)** > **Cancel Payment** (if Paid).
There was a problem hiding this comment.
@stephanieelliott this does seem outdated, right? Because that menu is definitely "More" in product.
There was a problem hiding this comment.
Yes this is wrong, I would ignore this one!
| 1. (Admins only) Open the report. | ||
| 2. Click **More > Cancel Payment** if Paid. | ||
| 2. Click **More > Cancel Payment** (if Paid). | ||
| 3. Then select **More > Unapprove**. |
There was a problem hiding this comment.
Naming convention violation: Same as above -- "More" must be replaced with the three dots reference. Per HELPSITE_NAMING_CONVENTIONS.md: Select the three dots **(⋮)**.
Suggested fix: 3. Then select the three dots **(⋮)** > **Unapprove**.
|
|
||
| **Note:** If the report was exported to accounting, delete it from that system before re-exporting. | ||
| After it’s unapproved: | ||
| - The member can select **More** > **Undo Submit**. |
There was a problem hiding this comment.
Naming convention violation: "More" must be replaced with the three dots reference per HELPSITE_NAMING_CONVENTIONS.md.
Suggested fix: - The member can select the three dots **(⋮)** > **Undo Submit**.
|
|
||
| **Follow these steps to create an expense that stays in your records but isn't submitted:** | ||
| There are two ways you can create an expense that stays in your records but isn't submitted: | ||
|
|
There was a problem hiding this comment.
Heading violation: ## SmartScan a Receipt does not start with an action verb imperative or a question word. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings must be task-based.
Suggested fix: ## How to SmartScan a receipt
| Other ways to SmartScan receipts include: | ||
| - Forward your digital receipts to `receipts@expensify.com`. | ||
| - Text a photo of your receipts to 47777 (US numbers only). Just make sure you [add your phone number to Expensify](https://new.expensify.com/settings/profile/contact-methods). | ||
|
|
There was a problem hiding this comment.
Heading violation: ## Manually Add an Expense -- while it contains an action verb, "Manually" is an adverb prefix that weakens searchability. Per HELP_AUTHORING_GUIDELINES.md Section 2, headings should be explicit and searchable task phrases.
Suggested fix: ## How to manually add an expense
| - Members without a default workspace will see the expense fields: Amount, Description, Merchant, Category, Date, Report. | ||
| 7. Click **Create expense**. | ||
|
|
||
| --- |
There was a problem hiding this comment.
Structure violation: # Where to Find Tracked Expenses uses a # heading. Per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading is allowed (the article title), plus # FAQ. All other content sections must use ##.
Suggested fix: ## Where to find tracked expenses
|
|
||
| After creating an expense, go to **Spend > Expenses** to find it. Use the filters to search for the expense if it isn't immediately visible. | ||
|
|
||
| After tracking an expense, it also appears in an **Expense Chat** in the left-hand navigation menu. |
There was a problem hiding this comment.
Structure violation: # What You Can Do With Tracked Expenses uses a # heading. Per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading is allowed (the article title), plus # FAQ. All other content sections must use ##.
Suggested fix: ## What you can do with tracked expenses
| 2. Choose yourself under Personal. | ||
| 3. Add details like description, category, tags, and tax. | ||
| 4. Tap **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. |
There was a problem hiding this comment.
Step formatting issue: Step numbering jumps from 3 to 5 (there is no step 4). The sub-bullets on lines 25-27 are not numbered steps, so the next step after step 3 should be step 4, not 5.
Suggested fix: Change 5. Tap **Create expense**. to 4. Tap **Create expense**.
| 2. Choose yourself under Personal. | ||
| 3. Add details like description, category, tags, and tax. | ||
| 4. Click **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. |
There was a problem hiding this comment.
Step formatting issue: Step numbering jumps from 3 to 5 (there is no step 4). Same issue as the mobile section above.
Suggested fix: Change 5. Click **Create expense**. to 4. Click **Create expense**.
| 4. Choose yourself under Personal. | ||
| 5. Add optional fields like category, tags, or description. | ||
| 6. Tap **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. |
There was a problem hiding this comment.
Step formatting issue: Step numbering jumps from 5 to 7 (there is no step 6). The sub-bullets on lines 51-52 are informational notes, not numbered steps.
Suggested fix: Change 7. Tap **Create expense**. to 6. Tap **Create expense**.
| 4. Choose yourself under Personal. | ||
| 5. Add optional fields like category, tags, or description. | ||
| 6. Click **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. |
There was a problem hiding this comment.
Step formatting issue: Step numbering jumps from 5 to 7 (there is no step 6). Same issue as the mobile section above.
Suggested fix: Change 7. Click **Create expense**. to 6. Click **Create expense**.
| - Once added, the **Submit** button appears in the header (replacing **Add expense**, which moves to the **More** menu) | ||
| ## Adding a New Expense to the Table | ||
| - The expense appears in the table. | ||
| - Its row is briefly highlighted as new. |
There was a problem hiding this comment.
Naming convention violation: Per HELPSITE_NAMING_CONVENTIONS.md, the three dots menu must never be called "More" or "More menu." The required format is: the three dots **(⋮)**.
Suggested fix: - Once added, the **Submit** button appears in the header (replacing **Add expense**, which moves to the three dots **(⋮)** menu).
| - **Empty draft reports**: Prompts you to add recent unreported expenses | ||
| - **Global create and quick actions**: Suggests “Create report” if you frequently submit grouped expenses | ||
| - **SelfDM**: Suggests unreported expenses to add to a report. | ||
| - **Empty draft reports**: Prompts you to add recent unreported expenses. |
There was a problem hiding this comment.
Formatting: This bullet is missing a period at the end, while the other bullets in this list (lines 116-117) end with periods. Keep punctuation consistent across all list items.
| --- | ||
| title: Track Expenses | ||
| description: Learn how to create and manage expenses in Expensify without submitting them for reimbursement or approval. | ||
| description: Learn how to create and manage expenses in New Expensify without submitting them for reimbursement or approval. |
There was a problem hiding this comment.
Missing required metadata: Per HELP_AUTHORING_GUIDELINES.md Section 3, every article must include an internalScope field in the YAML frontmatter. This field is missing. Also, the keywords on line 4 should be wrapped in brackets (e.g., [track expenses, create expense, ...]) to match the required format.
Example:
internalScope: Audience is [members]. Covers [tracking expenses without submitting], does not cover [submitting or approving reports].| - Visible to **all members** in the workspace chat | ||
| - Only the **creator** sees interactive options like **Add expense** | ||
| - **Workspace admins** can approve and pay a report | ||
| - Visible to **all members** in the workspace chat. |
There was a problem hiding this comment.
Button naming issue: The period is inside the bold formatting (**Add expense.**), which makes it appear as if the button label includes a period. Per HELPSITE_NAMING_CONVENTIONS.md, button names must match the UI exactly. Move the period outside the bold markers.
Suggested fix: - Only the **report creator** sees interactive options like **Add expense**.
|
A preview of your ExpensifyHelp changes have been deployed to https://34584211.helpdot.pages.dev ⚡️ Updated articles: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7b00ca98f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@lydiabarclay the rules the reviewer bot are following are in this file: HELP_AUTHORING_GUIDELINES.md You should be able to get Melvin to apply them for you in bulk if you wanted to! |
|
@MelvinBot why is the CLA Assistant test failing? the assignee |
|
The CLA check is failing because these commits were made via the GitHub web UI, which sets the committer to To fix: |
|
@MelvinBot can you suggest changes on this PR, rather than just leaving comments? |
MelvinBot
left a comment
There was a problem hiding this comment.
Here are the suggested changes based on the review comments. You can accept each one individually by clicking Apply suggestion or batch them with Add suggestion to batch.
| - Only the **creator** sees interactive options like **Add expense** | ||
| - **Workspace admins** can approve and pay a report | ||
| - Visible to **all members** in the workspace chat. | ||
| - Only the **report creator** sees interactive options like **Add expense.** |
There was a problem hiding this comment.
The period is inside the bold formatting, making it look like the button label includes a period. Move the period outside the bold markers.
| - Only the **report creator** sees interactive options like **Add expense.** | |
| - Only the **report creator** sees interactive options like **Add expense**. |
| **Note:** The bulk action menu appears after selecting at least one expense. | ||
|
|
||
| ## Steps to Move Expenses Between Reports | ||
| ## Moving Expenses Between Reports |
There was a problem hiding this comment.
Headings must be task-based per the help authoring guidelines. (Confirmed by stephanieelliott)
| ## Moving Expenses Between Reports | |
| ## How to move expenses between reports |
| - The expense appears in the table | ||
| - Its row is briefly highlighted as new | ||
| - Once added, the **Submit** button appears in the header (replacing **Add expense**, which moves to the **More** menu) | ||
| ## Adding a New Expense to the Table |
There was a problem hiding this comment.
Headings must be task-based per the help authoring guidelines.
| ## Adding a New Expense to the Table | |
| ## How to add a new expense to the table |
|
|
||
| # How to Use Filters to Find Reports and Expenses | ||
| Filters help you narrow down expenses or reports so you can find exactly what you need—fast. This is especially useful when you're working with a large dataset or trying to take specific actions, such as reporting unsubmitted expenses. | ||
| # Filters |
There was a problem hiding this comment.
Only one # heading is allowed per article (plus # FAQ), and headings must be task-based for search retrieval. (Confirmed by stephanieelliott)
| # Filters | |
| ## How to use filters to find reports and expenses |
| --- | ||
|
|
||
| # How to Use Smart Suggestions | ||
| # Smart Suggestions |
There was a problem hiding this comment.
Only one # heading is allowed per article (plus # FAQ), and headings must be task-based.
| # Smart Suggestions | |
| ## How to use Smart Suggestions |
| - Text a photo of your receipts to 47777 (US numbers only). Just make sure you [add your phone number to Expensify](https://new.expensify.com/settings/profile/contact-methods). | ||
|
|
||
| ## Option 2: Manually Add an Expense | ||
| ## Manually Add an Expense |
There was a problem hiding this comment.
Heading should be task-based per the help authoring guidelines.
| ## Manually Add an Expense | |
| ## How to manually add an expense |
| 6. Tap **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. | ||
| - Members without a default workspace will see the expense fields: Amount, Description, Merchant, Category, Date, Report. | ||
| 7. Tap **Create expense**. |
There was a problem hiding this comment.
Step numbering jumps from 5 to 7. Should be step 6.
| 7. Tap **Create expense**. | |
| 6. Tap **Create expense**. |
| 6. Click **Create expense**. | ||
| - Members with a default workspace will see expense fields that mirror their workspace's rules. | ||
| - Members without a default workspace will see the expense fields: Amount, Description, Merchant, Category, Date, Report. | ||
| 7. Click **Create expense**. |
There was a problem hiding this comment.
Step numbering jumps from 5 to 7. Should be step 6.
| 7. Click **Create expense**. | |
| 6. Click **Create expense**. |
| --- | ||
|
|
||
| # Locate and Manage Tracked Expenses | ||
| # Where to Find Tracked Expenses |
There was a problem hiding this comment.
Only one # heading is allowed per article (plus # FAQ). Must use ##.
| # Where to Find Tracked Expenses | |
| ## Where to find tracked expenses |
|
|
||
| After tracking an expense, it also appears in an **Expense Chat** in the left-hand navigation menu. | ||
|
|
||
| # What You Can Do With Tracked Expenses |
There was a problem hiding this comment.
Only one # heading is allowed per article (plus # FAQ). Must use ##.
| # What You Can Do With Tracked Expenses | |
| ## What you can do with tracked expenses |
|
Done! I've posted a review with GitHub suggestion blocks for 18 actionable items across all three files. Note: I skipped the "More" → "three dots" naming suggestions since |
Explanation of Change
Updating three articles in the context of unreported expense flow updates
Fixed Issues
https://github.com/Expensify/Expensify/issues/533133
no tests