Skip to content

Fix iOS - Expense - Pay button splits in half in landscape mode #90525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
May 18, 2026
+2 −2
Merged

Fix iOS - Expense - Pay button splits in half in landscape mode #90525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff7326b
Fix iOS - Expense - Pay button splits in half in landscape mode
GCyganek May 13, 2026
431d261
Fix ESlint and problem with too long label
GCyganek May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/ButtonWithDropdownMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function ButtonWithDropdownMenu<IValueType>({ref, ...props}: ButtonWithDropdownM
const dropdownAnchor = useRef<View | null>(null);
// We need to use isSmallScreenWidth instead of shouldUseNarrowLayout to apply correct popover styles
// eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
const {isSmallScreenWidth, isInLandscapeMode} = useResponsiveLayout();
const {isSmallScreenWidth} = useResponsiveLayout();
const dropdownButtonRef = isSplitButton ? buttonRef : mergeRefs(buttonRef, dropdownAnchor);
const selectedItem = options.at(selectedItemIndex) ?? options.at(0);
const areAllOptionsDisabled = options.every((option) => option.disabled);
Expand Down Expand Up @@ -177,7 +177,7 @@ function ButtonWithDropdownMenu<IValueType>({ref, ...props}: ButtonWithDropdownM
shouldStayNormalOnDisable={shouldStayNormalOnDisable}
isLoading={isLoading}
shouldRemoveRightBorderRadius
style={isSplitButton ? [styles.pr0, isInLandscapeMode ? undefined : styles.flex1] : {}}
style={isSplitButton ? [styles.pr0, styles.flexGrow1, styles.flexShrink1] : {}}
extraSmall={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.EXTRA_SMALL}
large={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.LARGE}
medium={buttonSize === CONST.DROPDOWN_BUTTON_SIZE.MEDIUM}
Expand Down
Loading