Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 210454209d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| html={translate( | ||
| 'workspace.accounting.chooseReconciliationAccount.settlementAccountReconciliation', | ||
| `${environmentURL}/${ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT.getRoute(policyID, Navigation.getActiveRoute())}`, | ||
| `${environmentURL}/${createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT.path)}`, |
There was a problem hiding this comment.
Screen.Recording.2026-04-03.at.13.06.06.mov
- Go to Workspace → Accounting → Card Reconciliation
- Open Reconciliation Account
- Tap the link “Expensify Card settlement account”
- Tap the link “Reconciliation account”
- Repeat steps 3–4 two times
@collectioneur Could you help me check this issue? When I open a dynamic page for the second time, the HTML link is no longer clickable.
What’s strange is that if the backTo param is not included, it works normally.
|
No product review needed |
Explanation of Change
Fixed Issues
$ #83864
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
CASE WORKSPACE_EXPENSIFY_CARD_LIMIT_TYPE
Precondition: The workspace has an Expensify card with at least one issued card
CASE WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW_CONFIRM_MAGIC_CODE
Precondition: The workspace has an Expensify card
CASE WORKSPACE_EXPENSIFY_CARD_SETTINGS_ACCOUNT
Precondition: The workspace has an Expensify card
Open the Expensify app
Go to Workspace → Expensify Cards → Settings
Open Settlement Account
Verify that the Settlement Account screen opens correctly
Navigating back returns to the previous screen correctly
CASE WORKSPACE_EXPENSIFY_CARD_SELECT_FEED
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-04-02.at.23.06.38.mp4