Open
Conversation
Remove "the" from "Set the merchant rules..." to read "Set merchant rules..." Co-authored-by: jamesdeanexpensify <jamesdean@expensify.com> Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 4f1c05a2..73bb5c46 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6656,7 +6656,7 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
},
merchantRules: {
title: 'Händler',
- subtitle: 'Legen Sie Händlerregeln fest, damit Spesen korrekt codiert ankommen und weniger Nachbearbeitung erfordern.',
+ subtitle: 'Legen Sie Händlerregeln fest, damit Ausgaben korrekt codiert ankommen und weniger Nachbearbeitung erfordern.',
addRule: 'Händlerregel hinzufügen',
addRuleTitle: 'Regel hinzufügen',
editRuleTitle: 'Regel bearbeiten',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 0e8a921d..483583d2 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -882,7 +882,7 @@ const translations: TranslationDeepObject<typeof en> = {
beginningOfChatHistory: (users: string) => `Cette discussion est avec ${users}.`,
beginningOfChatHistoryPolicyExpenseChat: (workspaceName: string, submitterDisplayName: string) =>
`C’est ici que <strong>${submitterDisplayName}</strong> soumettra des dépenses à <strong>${workspaceName}</strong>. Utilisez simplement le bouton +.`,
- beginningOfChatHistoryPolicyExpenseChatTrack: 'C\u2019est ici que vous suivrez vos dépenses',
+ beginningOfChatHistoryPolicyExpenseChatTrack: 'C’est ici que vous suivrez vos dépenses',
beginningOfChatHistorySelfDM: 'Ceci est votre espace personnel. Utilisez-le pour vos notes, tâches, brouillons et rappels.',
beginningOfChatHistorySystemDM: 'Bienvenue ! Procédons à la configuration.',
chatWithAccountManager: 'Discutez avec votre gestionnaire de compte ici',
@@ -6678,7 +6678,7 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
},
merchantRules: {
title: 'Commerçant',
- subtitle: 'Définissez les règles de commerçant pour que les dépenses arrivent correctement codées et nécessitent moins de nettoyage.',
+ subtitle: 'Définissez des règles de marchand afin que les dépenses arrivent correctement codées et nécessitent moins de nettoyage.',
addRule: 'Ajouter une règle de marchand',
addRuleTitle: 'Ajouter une règle',
editRuleTitle: 'Modifier la règle',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 5788af29..8162f8e3 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1096,15 +1096,12 @@ const translations: TranslationDeepObject<typeof en> = {
if (!added && !updated) {
return 'Nessuna categoria è stata aggiunta o aggiornata.';
}
-
if (added && updated) {
return `${added} ${added === 1 ? 'categoria aggiunta' : 'categorie aggiunte'}, ${updated} ${updated === 1 ? 'categoria aggiornata' : 'categorie aggiornate'}.`;
}
-
if (added) {
return added === 1 ? 'È stata aggiunta 1 categoria.' : `Sono state aggiunte ${added} categorie.`;
}
-
return updated === 1 ? 'È stata aggiornata 1 categoria.' : `Sono state aggiornate ${updated} categorie.`;
},
importCompanyCardTransactionsSuccessfulDescription: ({transactions}: {transactions: number}) =>
@@ -6644,7 +6641,7 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
},
merchantRules: {
title: 'Esercente',
- subtitle: 'Imposta le regole per l’esercente in modo che le spese arrivino già codificate correttamente e richiedano meno correzioni.',
+ subtitle: 'Imposta regole per gli esercenti così le spese arrivano già codificate correttamente e richiedono meno correzioni.',
addRule: 'Aggiungi regola esercente',
addRuleTitle: 'Aggiungi regola',
editRuleTitle: 'Modifica regola',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 363c2e61..dafc75b8 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1079,15 +1079,12 @@ const translations: TranslationDeepObject<typeof en> = {
if (!added && !updated) {
return 'カテゴリーは追加も更新もされていません。';
}
-
if (added && updated) {
return `${added}件のカテゴリーを追加し、${updated}件のカテゴリーを更新しました。`;
}
-
if (added) {
return added === 1 ? 'カテゴリーを1件追加しました。' : `${added}件のカテゴリーを追加しました。`;
}
-
return updated === 1 ? 'カテゴリーを1件更新しました。' : `${updated}件のカテゴリーを更新しました。`;
},
importCompanyCardTransactionsSuccessfulDescription: ({transactions}: {transactions: number}) =>
@@ -6573,7 +6570,7 @@ ${reportName}
},
merchantRules: {
title: '加盟店',
- subtitle: '経費が正しくコード化され、後処理が最小限で済むように、取引先ルールを設定しましょう。',
+ subtitle: '店舗ルールを設定して、経費が正しくコード化され、手直しの手間を減らせるようにします。',
addRule: '支払先ルールを追加',
addRuleTitle: 'ルールを追加',
editRuleTitle: 'ルールを編集',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 714fb587..492aa26b 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1095,15 +1095,12 @@ const translations: TranslationDeepObject<typeof en> = {
if (!added && !updated) {
return 'Er zijn geen categorieën toegevoegd of bijgewerkt.';
}
-
if (added && updated) {
return `${added} ${added === 1 ? 'categorie' : 'categorieën'} toegevoegd, ${updated} ${updated === 1 ? 'categorie' : 'categorieën'} bijgewerkt.`;
}
-
if (added) {
return added === 1 ? '1 categorie is toegevoegd.' : `${added} categorieën zijn toegevoegd.`;
}
-
return updated === 1 ? '1 categorie is bijgewerkt.' : `${updated} categorieën zijn bijgewerkt.`;
},
importCompanyCardTransactionsSuccessfulDescription: ({transactions}: {transactions: number}) =>
@@ -6625,7 +6622,7 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
},
merchantRules: {
title: 'Handelaar',
- subtitle: 'Stel de leveranciersregels in zodat onkosten correct gecodeerd binnenkomen en er minder nabewerking nodig is.',
+ subtitle: 'Stel handelaarregels in zodat uitgaven met de juiste codering binnenkomen en er minder nabewerking nodig is.',
addRule: 'Merchantregel toevoegen',
addRuleTitle: 'Regel toevoegen',
editRuleTitle: 'Regel bewerken',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index fa6da465..264b9dc3 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1096,15 +1096,12 @@ const translations: TranslationDeepObject<typeof en> = {
if (!added && !updated) {
return 'Nie dodano ani nie zaktualizowano żadnych kategorii.';
}
-
if (added && updated) {
return `Dodano ${added} ${added === 1 ? 'kategorię' : 'kategorie'}, zaktualizowano ${updated} ${updated === 1 ? 'kategorię' : 'kategorie'}.`;
}
-
if (added) {
return added === 1 ? 'Dodano 1 kategorię.' : `Dodano ${added} kategorie.`;
}
-
return updated === 1 ? 'Zaktualizowano 1 kategorię.' : `Zaktualizowano ${updated} kategorie.`;
},
importCompanyCardTransactionsSuccessfulDescription: ({transactions}: {transactions: number}) => (transactions > 1 ? `Dodano ${transactions} transakcji.` : 'Dodano 1 transakcję.'),
@@ -6618,7 +6615,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
},
merchantRules: {
title: 'Sprzedawca',
- subtitle: 'Skonfiguruj reguły dla sprzedawców, aby wydatki trafiały z prawidłowym kodowaniem i wymagały mniej poprawek.',
+ subtitle: 'Ustaw reguły dla sprzedawców, żeby wydatki trafiały od razu z poprawnym kodowaniem i wymagały mniej poprawek.',
addRule: 'Dodaj regułę dla sprzedawcy',
addRuleTitle: 'Dodaj regułę',
editRuleTitle: 'Edytuj regułę',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6e387c9a..2c24e529 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1094,15 +1094,12 @@ const translations: TranslationDeepObject<typeof en> = {
if (!added && !updated) {
return 'Nenhuma categoria foi adicionada ou atualizada.';
}
-
if (added && updated) {
return `${added} ${added === 1 ? 'categoria' : 'categorias'} adicionada${added === 1 ? '' : 's'}, ${updated} ${updated === 1 ? 'categoria' : 'categorias'} atualizada${updated === 1 ? '' : 's'}.`;
}
-
if (added) {
return added === 1 ? '1 categoria foi adicionada.' : `${added} categorias foram adicionadas.`;
}
-
return updated === 1 ? '1 categoria foi atualizada.' : `${updated} categorias foram atualizadas.`;
},
importCompanyCardTransactionsSuccessfulDescription: ({transactions}: {transactions: number}) =>
@@ -6623,7 +6620,7 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
},
merchantRules: {
title: 'Estabelecimento',
- subtitle: 'Defina as regras de estabelecimento para que as despesas cheguem corretamente classificadas e exijam menos retrabalho.',
+ subtitle: 'Defina regras de comerciante para que as despesas cheguem com a classificação correta e exijam menos retrabalho.',
addRule: 'Adicionar regra de comerciante',
addRuleTitle: 'Adicionar regra',
editRuleTitle: 'Editar regra',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 070f5626..67010045 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6449,7 +6449,7 @@ ${reportName}
},
merchantRules: {
title: '商户',
- subtitle: '设置商户规则,使报销费用自动使用正确的编码,并减少后期清理工作。',
+ subtitle: '设置商户规则,使报销单自动正确编码,减少后期整理工作。',
addRule: '添加商家规则',
addRuleTitle: '添加规则',
editRuleTitle: '编辑规则',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove "the" from the merchant rules subtitle copy.
Current: "Set the merchant rules so expenses arrive correctly coded and require less cleanup."
Updated: "Set merchant rules so expenses arrive correctly coded and require less cleanup."
Related Issues
#86973
Test plan
QA Steps
Same as test plan above.
Checklist
src/languages/en.tsCo-authored-by: jamesdeanexpensify jamesdean@expensify.com