[No QA] refactor: Extract LHNEmptyState from LHNOptionsList by BartekObudzinski · Pull Request #86964 · Expensify/App

BartekObudzinski · 2026-04-02T12:29:02Z

Explanation of Change

LHNOptionsList previously owned the entire empty-inbox UI inline: three hooks (useTheme, useMemoizedLazyExpensifyIcons, useEmptyLHNIllustration), one useMemo for subtitle JSX construction, and a conditional BlockingView render. These ran on every mount of LHNOptionsList, including the 99%+ of renders where data.length > 0 and the empty state is never shown.

This PR:

Extracts the empty state UI into a new LHNEmptyState component that only mounts when the inbox is actually empty
Moves the conditional to SidebarLinks (parent level), so LHNOptionsList never mounts with empty data
Removes dead code from LHNOptionsList: 3 hook calls, emptyLHNSubtitle useMemo (12 deps), conditional BlockingView render, and 7 unused imports. The "Woohoo! All caught up" logging useEffect has been relocated to LHNEmptyState where it actually fires.

ManualNavigateToInboxTab span benchmark (10 runs each, iOS Simulator, same session):

Metric	main	branch
Avg	675ms	622ms
Min	615ms	558ms
Max	761ms	724ms

Delta: -53ms (-7.8%). Perf-neutral to marginally better.

Validated against Onyx rules, React Compiler rules, React Native best practices, and Expensify coding standards. UI is identical between main and branch (verified via accessibility tree diff and visual screenshot comparison).

Fixed Issues

$ #87080
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-04-02T12:37:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/LHNOptionsList/LHNEmptyState.tsx	`100.00% <100.00%> (ø)`
src/components/LHNOptionsList/LHNOptionsList.tsx	`76.66% <100.00%> (-8.44%)`	⬇️
src/pages/inbox/sidebar/SidebarLinks.tsx	`92.85% <100.00%> (+1.19%)`	⬆️
... and 148 files with indirect coverage changes

Parent (SidebarLinks) now guards LHNOptionsList rendering, so the component never mounts when data is empty. Removed unreachable hooks, useMemo, and conditional BlockingView render. Kept the "Woohoo" logging useEffect for observability.

Remove !isLoadingReportData guard from shouldShowEmptyLHN to match the original LHNOptionsList behavior where the empty state renders regardless of loading state. The skeleton overlay handles the loading UI separately. Fixes SidebarOrderTest failure.

melvin-bot · 2026-04-03T12:36:49Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-04-03T12:45:02Z

Code Review

The extraction of LHNEmptyState is clean and the conditional lift to SidebarLinks is the right call for avoiding unnecessary hook execution. Two things to address:

1. Dead logging `useEffect` (bug)

The "Woohoo! All caught up" useEffect in LHNOptionsList.tsx:198-207 checks data.length === 0, but SidebarLinks now only mounts LHNOptionsList when optionListItems.length > 0. This condition can never be true — the logging is dead code despite the PR description stating it was intentionally kept for observability.

Fix: Move this useEffect into LHNEmptyState (or SidebarLinks next to the shouldShowEmptyLHN check) so it actually fires when the empty state renders.

2. PR description overclaims

The body lists 6 changes, but the diff only contains changes 1-3. Items 4 (remove duplicate useOnyx(REPORT_ACTIONS) from OptionRowLHNData), 5 (remove useConfirmReadyToOpenApp from SidebarLinks), and 6 (replace absoluteFillObject with absoluteFill) are not present in the diff. The description should be updated to match.

Everything else looks good — the component boundary is well-chosen, imports are cleaned up correctly, and the emptyLHNWrapper style is properly applied in the new location.

situchan · 2026-04-03T12:46:30Z

Removes a duplicate useOnyx(REPORT_ACTIONS) subscription from OptionRowLHNData (was identical to the existing reportActions prop)

Removes redundant useConfirmReadyToOpenApp from SidebarLinks (parent BaseSidebarScreen already calls it)

Replaces deprecated absoluteFillObject with absoluteFill

Looks like this is not related. Maybe copied form another PR?

situchan · 2026-04-03T12:49:53Z

src/components/LHNOptionsList/LHNOptionsList.tsx

+        if (data.length === 0) {
            Log.info('Woohoo! All caught up. Was rendered', false, {
                reportsCount: Object.keys(reports ?? {}).length,
                policyCount: Object.keys(policy ?? {}).length,
                personalDetailsCount: Object.keys(personalDetails ?? {}).length,
                reportsIDsFromUseReportsCount: data.length,
            });


This log should be relocated

Good catch. Moved the logging useEffect into LHNEmptyState where it actually fires on mount. Also removed the now-unused Log import from LHNOptionsList.

chatgpt-codex-connector · 2026-04-03T12:57:27Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

BartekObudzinski · 2026-04-03T13:44:43Z

Looks like this is not related. Maybe copied form another PR?

You are right, those items were from a different branch. Removed items 4-6 from the PR description. Only changes 1-3 are in this diff.

Also moved the dead logging useEffect from LHNOptionsList into LHNEmptyState where it actually fires on mount, as both reviewers flagged.

BartekObudzinski · 2026-04-03T13:48:47Z

I'm off on Monday since holiday in Poland

situchan · 2026-04-03T13:53:47Z

src/components/LHNOptionsList/LHNEmptyState.tsx

+        Log.info('Woohoo! All caught up. Was rendered', false, {
+            reportsCount: Object.keys(reports ?? {}).length,
+            policyCount: Object.keys(policy ?? {}).length,
+            personalDetailsCount: Object.keys(personalDetails ?? {}).length,


Should we log this only once on first time render? Now it's logged every time reports, policy or personalDetails is updated.
This was existing logic so not a blocker.

situchan · 2026-04-03T13:55:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

joekaufmanexpensify · 2026-04-03T20:45:31Z

No product review needed

melvin-bot bot assigned BartekObudzinski Apr 2, 2026

BartekObudzinski closed this Apr 2, 2026

BartekObudzinski reopened this Apr 2, 2026

refactor: extract LHNEmptyState, conditionally render from SidebarLinks

036b7d6

BartekObudzinski force-pushed the refactor/lhn-extract-empty-state branch from 9b2f868 to 036b7d6 Compare April 2, 2026 13:54

BartekObudzinski mentioned this pull request Apr 2, 2026

[Metrics] Improve ManualNavigateToInboxTab #77175

Open

BartekObudzinski added 3 commits April 3, 2026 08:27

fix: remove redundant useConfirmReadyToOpenApp from SidebarLinks

fa99d50

JS00001 mentioned this pull request Apr 3, 2026

Extract LHNEmptyState from LHNOptionsList #87080

Open

BartekObudzinski marked this pull request as ready for review April 3, 2026 12:36

BartekObudzinski requested review from a team as code owners April 3, 2026 12:36

melvin-bot bot requested a review from situchan April 3, 2026 12:36

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team April 3, 2026 12:36

JS00001 previously approved these changes Apr 3, 2026

View reviewed changes

situchan reviewed Apr 3, 2026

View reviewed changes

fix: relocate dead logging useEffect to LHNEmptyState

7090a59

BartekObudzinski dismissed JS00001’s stale review via 7090a59 April 3, 2026 13:46

situchan reviewed Apr 3, 2026

View reviewed changes

situchan approved these changes Apr 3, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 April 3, 2026 15:11

joekaufmanexpensify removed their request for review April 3, 2026 20:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] refactor: Extract LHNEmptyState from LHNOptionsList#86964

[No QA] refactor: Extract LHNEmptyState from LHNOptionsList#86964
BartekObudzinski wants to merge 5 commits intoExpensify:mainfrom
callstack-internal:refactor/lhn-extract-empty-state

BartekObudzinski commented Apr 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Apr 2, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

MelvinBot commented Apr 3, 2026

Uh oh!

situchan commented Apr 3, 2026

Uh oh!

situchan Apr 3, 2026

Uh oh!

BartekObudzinski Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 3, 2026

Uh oh!

BartekObudzinski commented Apr 3, 2026

Uh oh!

BartekObudzinski commented Apr 3, 2026

Uh oh!

situchan Apr 3, 2026

Uh oh!

situchan commented Apr 3, 2026 •

edited

Loading

Uh oh!

joekaufmanexpensify commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

BartekObudzinski commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

MelvinBot commented Apr 3, 2026

Code Review

1. Dead logging useEffect (bug)

2. PR description overclaims

Uh oh!

situchan commented Apr 3, 2026

Uh oh!

situchan Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Apr 3, 2026

Uh oh!

BartekObudzinski commented Apr 3, 2026

Uh oh!

BartekObudzinski commented Apr 3, 2026

Uh oh!

situchan Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

situchan commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BartekObudzinski commented Apr 2, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited by github-actions bot

Loading

1. Dead logging `useEffect` (bug)

situchan commented Apr 3, 2026 •

edited

Loading