-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Spend rule section #86572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spend rule section #86572
Changes from all commits
982ffe5
cfea7b8
d03e062
db5b4e2
e8413b0
2969fd4
b182a96
cd47b97
f66ef4b
ee5df9c
1f7c684
a30c3c5
6ede085
c6fcb67
ff05521
24c5096
82b1bb3
7965f36
dd07a74
f84d48d
c600f7b
3f52321
0222d81
9064897
9fc6980
123e1b1
7e424a4
ffc758f
20bb056
7ba295a
3a8eb77
354e097
3e12f16
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ import CONST from '@src/CONST'; | |
| import type SCREENS from '@src/SCREENS'; | ||
| import IndividualExpenseRulesSection from './IndividualExpenseRulesSection'; | ||
| import MerchantRulesSection from './MerchantRulesSection'; | ||
| import SpendRulesSection from './SpendRules/SpendRulesSection'; | ||
|
|
||
| type PolicyRulesPageProps = PlatformStackScreenProps<WorkspaceSplitNavigatorParamList, typeof SCREENS.WORKSPACE.RULES>; | ||
|
|
||
|
|
@@ -55,6 +56,7 @@ function PolicyRulesPage({route}: PolicyRulesPageProps) { | |
| <View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}> | ||
| <IndividualExpenseRulesSection policyID={policyID} /> | ||
| <MerchantRulesSection policyID={policyID} /> | ||
| {!!policy?.areExpensifyCardsEnabled && <SpendRulesSection />} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's hide this in prod for now, so we can test before we release this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was gonna leave this one in, since it's just the default rule and the modal. I was gonna hide the ability to add new rules in my 2nd PR. What do you think?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about that but I seemed to me like that's going to be confusing, specially since we have the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm cool with that. That said, advertising the default rule was the point of R1. So we're effectively not shipping anything until the later releases are done.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't block on this then. It seems weird to me, but I don't feel that strongly |
||
| </View> | ||
| </WorkspacePageWithSections> | ||
| </AccessOrNotFoundWrapper> | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.