Skip to content

[No QA] Update help docs to remove domain member requirement for card assignment#85723

Open
MelvinBot wants to merge 6 commits intomainfrom
claude-helpSiteRelease2OffDomainCards
Open

[No QA] Update help docs to remove domain member requirement for card assignment#85723
MelvinBot wants to merge 6 commits intomainfrom
claude-helpSiteRelease2OffDomainCards

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 19, 2026

Explanation of Change

Updates two Expensify Classic help articles to reflect Release 2 of the Universal Feed feature, which allows Domain Admins to assign Expensify Cards and company cards to any email address — not just members of their domain.

Changes:

  • Unlimited-Virtual-Cards.md: Removed the domain member restriction from the setup description and updated step 4 to say "Enter the email address" instead of "Select a domain member"
  • Manage-Company-Cards.md: Updated step 3 in the Assign Cards section to clarify that any email address can be entered when assigning cards

Fixed Issues

https://github.com/Expensify/Expensify/issues/590511

Tests

  • Verified markdown renders correctly
  • Confirmed changes match the Release 2 scope described in the issue (remove domain member requirement, specify any email can be entered)
  • No structural changes to articles — only targeted text updates

Web QA

No QA needed — documentation-only changes.

Mobile QA

No mobile QA.

Release 2 of the Universal Feed feature allows domain admins to assign
cards to any email address, not just domain members. Updated both the
Unlimited Virtual Cards and Manage Company Cards articles to reflect
this change.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 19, 2026 01:51
@MelvinBot
Copy link
Contributor Author

Fixed the failing spellcheck: corrected typo cirtualvirtual in Unlimited-Virtual-Cards.md (line 51).

@stephanieelliott stephanieelliott marked this pull request as ready for review March 19, 2026 02:17
@stephanieelliott stephanieelliott self-requested a review as a code owner March 19, 2026 02:17
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @NicMendonca

@melvin-bot melvin-bot bot requested a review from NicMendonca March 19, 2026 02:17
@melvin-bot
Copy link

melvin-bot bot commented Mar 19, 2026

@NicMendonca Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 19, 2026 02:17
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates two Expensify Classic help articles to reflect the Release 2 change that allows Domain Admins to assign Expensify Cards and company cards to any email address, removing the previous domain-member-only restriction. The content changes are accurate and well-aligned with the stated purpose. The PR also improves FAQ headings in Manage-Company-Cards.md and converts several noun-based headings to task-based "How to" headings in Unlimited-Virtual-Cards.md. However, there are two heading-level violations in the Unlimited-Virtual-Cards.md changes that must be addressed before merging.

Scores Summary

  • Readability: 8/10 - The changes improve clarity across both files. FAQ headings are now clean question-form headings instead of the old "Topic: Question" pattern. Step instructions are more actionable (e.g., "enter the member's email address" replacing "select the employee's email"). Minor trailing whitespace on a few changed lines.
  • AI Readiness: 5/10 - The conversion of noun-based headings to "How to..." format is a strong improvement for retrieval. However, two heading-level violations undermine the structure: a second # title heading (# Unlimited Virtual Cards) was added mid-body, and # How to terminate a virtual card remains at # level instead of ##. These break the "exactly one # heading (title) plus optional # FAQ" rule from the authoring guidelines, which directly impacts how AI systems parse document hierarchy. Additionally, the internalScope field remains absent from both files' YAML frontmatter.
  • Style Compliance: 7/10 - Good consistency improvements: "Domain Admins" capitalization is now uniform, and "member" terminology replaces the outdated "employee"/"domain member" phrasing. FAQ headings now properly start with question words. The heading-level violations noted above also count against style compliance.

Key Findings

Must fix (introduced in this diff):

  • In Unlimited-Virtual-Cards.md, line # How to terminate a virtual card uses a # heading where it must be ##. Per HELP_AUTHORING_GUIDELINES.md Section 4 and the Pre-Publish Validation Checklist: "Exactly one # heading (the article title), plus optional # FAQ -- no other # headings." All content section headings must use ##.
  • In Unlimited-Virtual-Cards.md, a new # Unlimited Virtual Cards heading was added in the body after the intro paragraph. This creates a second #-level title in the article, violating the same rule. This heading should either be removed (the YAML title already serves as the article title) or converted to ## with a task-based phrasing.

Worth noting (pre-existing but relevant to the changed sections):

  • Both files lack the internalScope field in their YAML frontmatter, which is required per HELP_AUTHORING_GUIDELINES.md Section 3 and TEMPLATE.md. Since the YAML block in Unlimited-Virtual-Cards.md was touched (trailing whitespace trimmed), this would have been a good opportunity to add it.
  • Several changed lines have trailing whitespace (e.g., the step 3 line in Manage-Company-Cards.md, and two FAQ headings). While minor, these should be cleaned up.

Positive aspects:

  • The FAQ heading reformatting in Manage-Company-Cards.md is an excellent improvement. Removing the "Topic:" prefix pattern and using clean question-form headings (e.g., "Why are some transactions missing?" instead of "Missing Transactions: Why aren't all transactions appearing?") aligns well with governance rules and improves scannability.
  • Converting # Set up Virtual Cards and # Edit Virtual Cards to ## How to set up virtual cards and ## How to edit virtual cards is exactly the kind of improvement the authoring guidelines call for -- task-based, properly leveled, and searchable.
  • The terminology update from "employee"/"domain member" to "member" and consistent "Domain Admins" capitalization improves deterministic writing and consistency.
  • The content changes accurately reflect the new feature behavior (card assignment to any email, not restricted to domain members).

Recommendations

  1. [Required] Change # How to terminate a virtual card to ## How to terminate a virtual card in Unlimited-Virtual-Cards.md.
  2. [Required] Either remove the added # Unlimited Virtual Cards heading from the body (since the YAML title already provides this), or restructure it as a ## heading with a task-based phrasing (e.g., ## What unlimited virtual cards are used for).
  3. [Suggested] Add the internalScope field to the YAML frontmatter of both files while they are being edited.
  4. [Suggested] Remove trailing whitespace from changed lines (step 3 in Manage-Company-Cards.md, FAQ heading lines).

Files Reviewed

  • docs/articles/expensify-classic/connect-credit-cards/Manage-Company-Cards.md - Content update is clean and FAQ headings are well-improved. Minor trailing whitespace on changed lines.
  • docs/articles/expensify-classic/expensify-card/Unlimited-Virtual-Cards.md - Good content and terminology updates, but two heading-level violations in the diff must be corrected before merge.

@github-actions github-actions bot changed the title Update help docs to remove domain member requirement for card assignment [No QA] Update help docs to remove domain member requirement for card assignment Mar 19, 2026
@OSBotify
Copy link
Contributor

OSBotify commented Mar 19, 2026

…al-Cards.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott
Copy link
Contributor

Resolved all bot comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants