Action badge follow-ups: deep link to reportAction and remove Pinned text

src/components/LHNOptionsList/OptionRowLHN.tsx

@@ -434,28 +434,18 @@ function OptionRowLHN({
                                                 />
                                             </View>
                                         )}
-                                        {!brickRoadIndicator &&
-                                            !!optionItem.isPinned &&
-                                            (isProduction ? (
-                                                <View
-                                                    style={styles.ml2}
-                                                    accessibilityLabel={translate('sidebarScreen.chatPinned')}
-                                                >
-                                                    <Icon
-                                                        testID="Pin Icon"
-                                                        fill={theme.icon}
-                                                        src={expensifyIcons.Pin}
-                                                    />
-                                                </View>
-                                            ) : (
-                                                <Badge
-                                                    icon={expensifyIcons.Pin}
-                                                    text={translate('common.pinned')}
-                                                    badgeStyles={isOptionFocused && styles.badgeDefaultActive}
-                                                    isCondensed
-                                                    isStrong
+                                        {!brickRoadIndicator && !!optionItem.isPinned && (
+                                            <View
+                                                style={styles.ml2}
+                                                accessibilityLabel={translate('sidebarScreen.chatPinned')}
+                                            >
+                                                <Icon
+                                                    testID="Pin Icon"
+                                                    fill={theme.icon}
+                                                    src={expensifyIcons.Pin}
                                                 />
-                                            ))}
+                                            </View>
+                                        )}
                                     </View>
                                 </PressableWithSecondaryInteraction>
                             );

src/components/LHNOptionsList/OptionRowLHNData.tsx

@@ -114,6 +114,7 @@ function OptionRowLHNData({
         fullReport,
         reportAttributes?.brickRoadStatus,
         reportAttributes?.actionBadge,
+        reportAttributes?.actionBadgeReportActionID,
         reportAttributes?.reportName,
         areReportErrorsEqual,
         oneTransactionThreadReport,

src/libs/ReportUtils.ts

@@ -833,6 +833,7 @@
     allReportErrors?: Errors;
     brickRoadIndicator?: ValueOf<typeof CONST.BRICK_ROAD_INDICATOR_STATUS> | '' | null;
     actionBadge?: ValueOf<typeof CONST.REPORT.ACTION_BADGE>;
+    actionBadgeReportActionID?: string;
     tooltipText?: string | null;
     alternateTextMaxLines?: number;
     boldStyle?: boolean;
@@ -1036,7 +1037,7 @@
 };
 
 let conciergeReportIDOnyxConnect: OnyxEntry<string>;
 Onyx.connect({
     key: ONYXKEYS.CONCIERGE_REPORT_ID,
     callback: (value) => {
         conciergeReportIDOnyxConnect = value;
@@ -1044,7 +1045,7 @@
 });
 
 const defaultAvatarBuildingIconTestID = 'SvgDefaultAvatarBuilding Icon';
 Onyx.connect({
     key: ONYXKEYS.SESSION,
     callback: (value) => {
         // When signed out, val is undefined
@@ -1062,7 +1063,7 @@
 let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
 let allPersonalDetailLogins: string[];
 let currentUserPersonalDetails: OnyxEntry<PersonalDetails>;
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => {
         if (currentUserAccountID) {
@@ -1074,7 +1075,7 @@
 });
 
 let allReportsDraft: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_DRAFT,
     waitForCollectionCallback: true,
     callback: (value) => (allReportsDraft = value),
@@ -1082,7 +1083,7 @@
 
 let allPolicies: OnyxCollection<Policy>;
 let policiesArray: Policy[] = [];
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1092,7 +1093,7 @@
 });
 
 let allPolicyDrafts: OnyxCollection<Policy>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY_DRAFTS,
     waitForCollectionCallback: true,
     callback: (value) => (allPolicyDrafts = value),
@@ -1100,7 +1101,7 @@
 
 let allReports: OnyxCollection<Report>;
 let reportsByPolicyID: ReportByPolicyMap;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1136,14 +1137,14 @@
 });
 
 let betaConfiguration: OnyxEntry<BetaConfiguration> = {};
 Onyx.connect({
     key: ONYXKEYS.BETA_CONFIGURATION,
     callback: (value) => (betaConfiguration = value ?? {}),
 });
 
 let deprecatedAllTransactions: OnyxCollection<Transaction> = {};
 let deprecatedReportsTransactions: Record<string, Transaction[]> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.TRANSACTION,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -1169,7 +1170,7 @@
 });
 
 let allReportActions: OnyxCollection<ReportActions>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
     waitForCollectionCallback: true,
     callback: (actions) => {
@@ -9137,6 +9138,80 @@
     });
 }
 
+/**
+ * Returns the reportID of the first child expense report that has violations under the same policy,
+ * or undefined if none found. Used to find the REPORT_PREVIEW action to deep-link to.
+ */
+function getViolatingReportIDForLHN(report: OnyxEntry<Report>, transactionViolations: OnyxCollection<TransactionViolation[]>): string | undefined {
+    if (!report || !isPolicyExpenseChat(report)) {
+        return undefined;
+    }
+
+    if (!isCurrentUserSubmitter(report)) {
+        return undefined;
+    }
+    if (!report.policyID || !reportsByPolicyID) {
+        return undefined;
+    }
+
+    const potentialReports = Object.values(reportsByPolicyID[report.policyID] ?? {}) ?? [];
+    const violatingReport = potentialReports.find((potentialReport) => {
+        if (!potentialReport) {
+            return false;
+        }
+        const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${potentialReport.policyID}`];
+        const transactions = getReportTransactions(potentialReport.reportID);
+
+        if (!isOpenOrProcessingReport(potentialReport)) {
+            return false;
+        }
+
+        return (
+            !isInvoiceReport(potentialReport) &&
+            ViolationsUtils.hasVisibleViolationsForUser(
+                potentialReport,
+                transactionViolations,
+                currentUserEmail ?? '',
+                currentUserAccountID ?? CONST.DEFAULT_NUMBER_ID,
+                policy,
+                transactions,
+            ) &&
+            (hasViolations(
+                potentialReport.reportID,
+                transactionViolations,
+                currentUserAccountID ?? CONST.DEFAULT_NUMBER_ID,
+                currentUserEmail ?? '',
+                true,
+                transactions,
+                potentialReport,
+                policy,
+            ) ||
+                hasWarningTypeViolations(
+                    potentialReport.reportID,
+                    transactionViolations,
+                    currentUserAccountID ?? CONST.DEFAULT_NUMBER_ID,
+                    currentUserEmail ?? '',
+                    true,
+                    transactions,
+                    potentialReport,
+                    policy,
+                ) ||
+                hasNoticeTypeViolations(
+                    potentialReport.reportID,
+                    transactionViolations,
+                    currentUserAccountID ?? CONST.DEFAULT_NUMBER_ID,
+                    currentUserEmail ?? '',
+                    true,
+                    transactions,
+                    potentialReport,
+                    policy,
+                ))
+        );
+    });
+
+    return violatingReport?.reportID;
+}
+
 /**
  * Checks to see if a report contains a violation
  */
@@ -12714,7 +12789,7 @@
     const hasErrors = Object.entries(reportErrors ?? {}).length > 0;
     const oneTransactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActionsList);
     const parentReportAction = report?.parentReportActionID ? parentReportActionsList?.[report.parentReportActionID] : undefined;
-    const {reason, actionBadge} = getReasonAndReportActionThatRequiresAttention(report, parentReportAction, isReportArchived) ?? {};
+    const {reason, reportAction: attentionReportAction, actionBadge} = getReasonAndReportActionThatRequiresAttention(report, parentReportAction, isReportArchived) ?? {};
 
     return {
         hasViolationsToDisplayInLHN,
@@ -12725,6 +12800,7 @@
         parentReportAction,
         requiresAttention: !!reason,
         actionBadge,
+        actionBadgeReportActionID: attentionReportAction?.reportActionID,
     };
 }
 
@@ -13378,6 +13454,7 @@
     shouldDisableThread,
     shouldDisplayThreadReplies,
     shouldDisplayViolationsRBRInLHN,
+    getViolatingReportIDForLHN,
     shouldReportBeInOptionList,
     shouldReportShowSubscript,
     shouldShowFlagComment,

src/libs/SidebarUtils.ts

@@ -125,6 +125,7 @@ import {
     isInviteOrRemovedAction,
     isOldDotReportAction,
     isRenamedAction,
+    isReportPreviewAction,
     isTagModificationAction,
     isTaskAction,
 } from './ReportActionsUtils';
@@ -151,6 +152,7 @@ import {
     getReportParticipantsTitle,
     getReportSubtitlePrefix,
     getUnreportedTransactionMessage,
+    getViolatingReportIDForLHN,
     getWorkspaceNameUpdatedMessage,
     hasReportErrorsOtherThanFailedReceipt,
     isAdminRoom,
@@ -635,9 +637,12 @@ function getReasonAndReportActionThatHasRedBrickRoad(
         return null;
     }
 
-    if (shouldDisplayViolationsRBRInLHN(report, transactionViolations)) {
+    const violatingReportID = getViolatingReportIDForLHN(report, transactionViolations);
+    if (violatingReportID) {
+        const reportPreviewAction = Object.values(reportActions ?? {}).find((action) => isReportPreviewAction(action) && getOriginalMessage(action)?.linkedReportID === violatingReportID);
         return {
             reason: CONST.RBR_REASONS.HAS_TRANSACTION_THREAD_VIOLATIONS,
+            reportAction: reportPreviewAction,
         };
     }
 
@@ -792,6 +797,7 @@ function getOptionData({
     result.pendingAction = report.pendingFields?.addWorkspaceRoom ?? report.pendingFields?.createChat;
     result.brickRoadIndicator = reportAttributes?.brickRoadStatus;
     result.actionBadge = reportAttributes?.actionBadge;
+    result.actionBadgeReportActionID = reportAttributes?.actionBadgeReportActionID;
     result.ownerAccountID = report.ownerAccountID;
     result.managerID = report.managerID;
     result.reportID = report.reportID;

src/libs/actions/OnyxDerived/configs/reportAttributes.ts

@@ -209,6 +209,7 @@ export default createOnyxDerivedValueConfig({
                 reportErrors,
                 oneTransactionThreadReportID,
                 actionBadge: actionGreenBadge,
+                actionBadgeReportActionID: greenBadgeReportActionID,
             } = generateReportAttributes({
                 report,
                 chatReport,
@@ -219,15 +220,28 @@ export default createOnyxDerivedValueConfig({
 
             let brickRoadStatus;
             let actionBadge;
+            let actionBadgeReportActionID;
             // if report has errors or violations, show red dot
-            if (SidebarUtils.shouldShowRedBrickRoad(report, chatReport, reportActionsList, hasAnyViolations, reportErrors, transactions, transactionViolations, !!isReportArchived)) {
+            const reasonAndReportAction = SidebarUtils.getReasonAndReportActionThatHasRedBrickRoad(
+                report,
+                chatReport,
+                reportActionsList,
+                hasAnyViolations,
+                reportErrors,
+                transactions,
+                transactionViolations,
+                !!isReportArchived,
+            );
+            if (reasonAndReportAction) {
                 brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
                 actionBadge = CONST.REPORT.ACTION_BADGE.FIX;
+                actionBadgeReportActionID = reasonAndReportAction.reportAction?.reportActionID;
             }
             // if report does not have error, check if it should show green dot
             if (brickRoadStatus !== CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR && requiresAttention) {
                 brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
                 actionBadge = actionGreenBadge;
+                actionBadgeReportActionID = greenBadgeReportActionID;
             }
 
             acc[report.reportID] = {
@@ -249,6 +263,7 @@ export default createOnyxDerivedValueConfig({
                 brickRoadStatus,
                 requiresAttention,
                 actionBadge,
+                actionBadgeReportActionID,
                 reportErrors,
                 oneTransactionThreadReportID,
             };

src/pages/inbox/sidebar/SidebarLinks.tsx

@@ -16,6 +16,7 @@ import {cancelSpan} from '@libs/telemetry/activeSpans';
 import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
 import * as ReportActionContextMenu from '@pages/inbox/report/ContextMenu/ReportActionContextMenu';
 import CONST from '@src/CONST';
+import type {OptionData} from '@src/libs/ReportUtils';
 import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type {Report} from '@src/types/onyx';
@@ -51,7 +52,7 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
      * Show Report page with selected report id
      */
     const showReportPage = useCallback(
-        (option: Report) => {
+        (option: OptionData) => {
             // Prevent opening Report page when clicking LHN row quickly after clicking FAB icon
             // or when clicking the active LHN row on large screens
             // or when continuously clicking different LHNs, only apply to small screen
@@ -70,7 +71,7 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
                 cancelSpan(`${CONST.TELEMETRY.SPAN_OPEN_REPORT}_${option.reportID}`);
                 return;
             }
-            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(option.reportID));
+            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(option.reportID, option.actionBadgeReportActionID));
         },
         [shouldUseNarrowLayout, isActiveReport],
     );

src/types/onyx/DerivedValues.ts

@@ -33,6 +33,10 @@ type ReportAttributes = {
      * The action badge to display instead of the GBR/RBR dot (e.g. 'submit', 'approve', 'pay').
      */
     actionBadge?: ValueOf<typeof CONST.REPORT.ACTION_BADGE>;
+    /**
+     * The reportActionID associated with the action badge, used for deep-linking from LHN.
+     */
+    actionBadgeReportActionID?: string;
     /**
      * The errors of the report.
      */