[HOLD] Send HTML for bespokeWelcomeMessage to fix formatting on followup arrival by marcochavezf · Pull Request #85127 · Expensify/App

marcochavezf · 2026-03-12T19:34:37Z

Explanation of Change

The frontend creates the bespoke welcome message as markdown via getBespokeWelcomeMessage(), converts it to HTML via getParsedComment() for the optimistic render, but was sending the raw markdown to the backend as the bespokeWelcomeMessage API param. The backend passes this to the LLM as "html" verbatim. When the server response came back, the message had plain \n instead of <br> tags, causing formatting to break momentarily until re-render.

This PR sends the already-parsed HTML (from getParsedComment()) as the bespokeWelcomeMessage param, so the backend receives actual HTML and passes it through correctly. The optimistic action continues to work the same since it already uses the HTML version internally.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/610148

Tests

Sign up as a new 1-10 company size user with the suggestedFollowups beta enabled (let's use the @dmb.fun domain without +)
Complete onboarding and observe the Concierge welcome message in the admin chat
Wait for the server response / followups to arrive
Verify the welcome message formatting remains consistent (no momentary formatting break with raw newlines)

Verify that no errors appear in the JS console

Offline tests

N/A - This change affects the API parameter format, which only matters when online.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The frontend was sending raw markdown as the bespokeWelcomeMessage param to the backend, but the backend passes it to the LLM as HTML for AddComment. This caused formatting to break when the server response replaced the optimistic render. Now we call getParsedComment() on the bespoke message before sending it, matching the HTML format that the optimistic action already uses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot · 2026-03-12T19:34:45Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.ts

…edComment call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

hoangzinh · 2026-03-12T22:42:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-13.at.06.19.30.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-03-13.at.06.28.56.mov

iOS: mWeb Safari

Screen.Recording.2026-03-13.at.06.24.53.mov

MacOS: Chrome / Safari

hoangzinh · 2026-03-12T23:12:06Z

@marcochavezf The code looks good to me. However, for the testing step, we should note for QA that using email without "+" to generate the bespokeWelcomeMessage.

App/src/libs/ReportUtils.ts

Lines 12290 to 12299 in 8f773d3

    
           /** 
        
            * Whether onboarding tasks should be posted in the #admins room instead of Concierge. 
        
            * Only the "Manage my team's expenses" (MANAGE_TEAM) intent uses the #admins room with a guide; 
        
            * Track and budget expenses (TRACK_WORKSPACE) uses Concierge chat. Guides are assigned to users who sign up 
        
            * with emails that do not contain a '+' and who select MANAGE_TEAM. 
        
            */ 
        
           function isPostingTasksInAdminsRoom(engagementChoice?: OnboardingPurpose): boolean { 
        
               const userHasPhonePrimaryEmail = Str.endsWith(currentUserEmail ?? '', CONST.SMS.DOMAIN); 
        
               return engagementChoice !== undefined && engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && (!currentUserEmail?.includes('+') || userHasPhonePrimaryEmail); 
        
           }

marcochavezf · 2026-03-12T23:28:52Z

@marcochavezf The code looks good to me. However, for the testing step, we should note for QA that using email without "+" to generate the bespokeWelcomeMessage.

App/src/libs/ReportUtils.ts

Lines 12290 to 12299 in 8f773d3

/**

* Whether onboarding tasks should be posted in the #admins room instead of Concierge.

* Only the "Manage my team's expenses" (MANAGE_TEAM) intent uses the #admins room with a guide;

* Track and budget expenses (TRACK_WORKSPACE) uses Concierge chat. Guides are assigned to users who sign up

* with emails that do not contain a '+' and who select MANAGE_TEAM.

*/

function isPostingTasksInAdminsRoom(engagementChoice?: OnboardingPurpose): boolean {

const userHasPhonePrimaryEmail = Str.endsWith(currentUserEmail ?? '', CONST.SMS.DOMAIN);

return engagementChoice !== undefined && engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && (!currentUserEmail?.includes('+') || userHasPhonePrimaryEmail);

}

Thanks for catching that, I updated the test steps

hoangzinh

LGTM

melvin-bot · 2026-03-12T23:30:56Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-12T23:30:58Z

🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #85148.

marcochavezf · 2026-03-13T00:13:41Z

After testing again I realized we need to update the backend for this case

marcochavezf · 2026-03-13T00:52:39Z

BE PR in review https://github.com/Expensify/Web-Expensify/pull/51367

marcochavezf requested review from a team as code owners March 12, 2026 19:34

melvin-bot bot assigned marcochavezf Mar 12, 2026

melvin-bot bot requested review from hoangzinh and removed request for a team March 12, 2026 19:34

melvin-bot bot requested review from trjExpensify and removed request for a team March 12, 2026 19:34

github-actions bot reviewed Mar 12, 2026

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

Reuse parsed HTML from optimistic action instead of duplicate getPars…

f39b98b

…edComment call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

hoangzinh approved these changes Mar 12, 2026

View reviewed changes

melvin-bot bot requested a review from madmax330 March 12, 2026 23:30

melvin-bot bot mentioned this pull request Mar 12, 2026

Payment issue for E/App PR#85127 #85148

Open

marcochavezf changed the title ~~Send HTML for bespokeWelcomeMessage to fix formatting on followup arrival~~ [HOLD] Send HTML for bespokeWelcomeMessage to fix formatting on followup arrival Mar 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD] Send HTML for bespokeWelcomeMessage to fix formatting on followup arrival#85127

[HOLD] Send HTML for bespokeWelcomeMessage to fix formatting on followup arrival#85127
marcochavezf wants to merge 2 commits intomainfrom
marco/fix-610148-bespoke-welcome-html

marcochavezf commented Mar 12, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

Uh oh!

hoangzinh commented Mar 12, 2026 •

edited

Loading

Uh oh!

hoangzinh commented Mar 12, 2026 •

edited

Loading

Uh oh!

marcochavezf commented Mar 12, 2026

Uh oh!

hoangzinh left a comment

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

marcochavezf commented Mar 13, 2026

Uh oh!

marcochavezf commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

marcochavezf commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

Uh oh!

hoangzinh commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcochavezf commented Mar 12, 2026

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

marcochavezf commented Mar 13, 2026

Uh oh!

marcochavezf commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marcochavezf commented Mar 12, 2026 •

edited

Loading

hoangzinh commented Mar 12, 2026 •

edited

Loading

hoangzinh commented Mar 12, 2026 •

edited

Loading