Skip to content

Add sandbox attribute to EmbeddedDemo iframe to prevent blocked navigation#85125

Draft
MelvinBot wants to merge 1 commit intomainfrom
claude-fixTestDriveIframeBlocking
Draft

Add sandbox attribute to EmbeddedDemo iframe to prevent blocked navigation#85125
MelvinBot wants to merge 1 commit intomainfrom
claude-fixTestDriveIframeBlocking

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 12, 2026

Explanation of Change

When a new user clicks "Take a 2-minute test drive," a Storylane interactive tour opens in an iframe. If the user clicks the Expensify logo inside the tour, the iframe navigates to www.storylane.io, which returns anti-framing headers (X-Frame-Options: SAMEORIGIN and CSP frame-ancestors 'self'), causing the browser to display "This content is blocked."

This PR adds the sandbox attribute to the <iframe> in EmbeddedDemo with allow-scripts allow-same-origin allow-popups allow-popups-to-escape-sandbox. By omitting allow-top-navigation, the browser blocks the iframe from navigating itself to the non-embeddable URL, while the Storylane tour continues to function normally (scripts, same-origin access, and popups still work).

Fixed Issues

$ #82517
PROPOSAL: #82517 (comment)

Tests

  1. Sign up a new account on a public domain
  2. Click on GAB > Take a 2-minute test drive
  3. Verify the Storylane tour loads and is interactive (click through steps)
  4. Click the Expensify logo in the top-left corner of the tour
  5. Verify the iframe does NOT navigate to a broken "This content is blocked" page
  6. Verify the tour remains functional after clicking the logo
  • Verify that no errors appear in the JS console

Offline tests

N/A — the embedded demo requires an internet connection to load the Storylane tour. The sandbox attribute is a static HTML attribute that does not depend on network state.

QA Steps

  1. Sign up a new account on a public domain
  2. Click on GAB > Take a 2-minute test drive
  3. Verify the Storylane tour loads and is interactive
  4. Click the Expensify logo in the top-left corner of the tour
  5. Verify the iframe does NOT show "This content is blocked" — the tour should remain on its current page or do nothing
  6. Verify the tour is still fully interactive after clicking the logo
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — change is web-only (iframe sandbox attribute)

Android: mWeb Chrome

N/A — change is web-only (iframe sandbox attribute)

iOS: Native

N/A — change is web-only (iframe sandbox attribute)

iOS: mWeb Safari

N/A — change is web-only (iframe sandbox attribute)

MacOS: Chrome / Safari

@MelvinBot @ShridharGoel
Fix: Add sandbox attribute to EmbeddedDemo iframe to prevent blocked …
9e3232a 
…navigation

The Storylane test drive tour iframe navigates to www.storylane.io when the
Expensify logo is clicked, but that page blocks framing via X-Frame-Options
and CSP headers, showing "This content is blocked." Adding the sandbox
attribute without allow-top-navigation prevents the iframe from navigating
to non-embeddable URLs while keeping the tour functional.

Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 12, 2026 18:28
@MelvinBot MelvinBot mentioned this pull request Mar 12, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ShridharGoel ShridharGoel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @ShridharGoel