Add accessibilityLabel to picker dismiss button for VoiceOver by MelvinBot · Pull Request #85103 · Expensify/App

MelvinBot · 2026-03-12T15:36:26Z

Explanation of Change

The iOS picker's dismiss/Done button was not being announced by VoiceOver because it lacked an accessibilityLabel. The library (react-native-picker-select) already exposes touchableDoneProps for this purpose — we were passing accessibilityRole: 'button' but not an accessibilityLabel.

This adds accessibilityLabel: translate('common.dismiss') to the touchableDoneProps in BasePicker, so VoiceOver now announces the button as "Dismiss" (localized).

Fixed Issues

$ #77534

Tests

Precondition

You should be signed out

Using iOS VoiceOver, open the Expensify app
Swipe to the language dropdown button and double-tap to activate
Swipe to the 'Done' button
Swipe once left to focus to the done button
Verify that it announces it as 'Dismiss' button

Verify that no errors appear in the JS console

Offline tests

N/A — accessibility label is a static UI attribute unrelated to network state.

QA Steps

Precondition

You should be signed out

Using iOS VoiceOver, open the Expensify app
Swipe to the language dropdown button and double-tap to activate
Swipe to the 'Done' button
Swipe once left to focus to the done button
Verify that it announces it as 'Dismiss' button

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — iOS-only picker behavior

Android: mWeb Chrome

N/A — iOS-only picker behavior

iOS: Native

iOS: mWeb Safari

N/A — native picker only

MacOS: Chrome / Safari

N/A — iOS-only picker behavior

Pass accessibilityLabel with 'Dismiss' copy via touchableDoneProps in BasePicker so the iOS picker dismiss button is announced by VoiceOver. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

melvin-bot · 2026-03-12T15:36:31Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

MelvinBot · 2026-03-12T15:36:40Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-addDismissAccessibilityLabel
git checkout -b claude-addDismissAccessibilityLabel upstream/claude-addDismissAccessibilityLabel
git push -u origin claude-addDismissAccessibilityLabel

Then you can close this PR and open a new one from your fork.

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-03-12T15:39:42Z

Fixed the failing Prettier check: the useLocalize and useScrollContext imports in BasePicker.tsx were not in alphabetical order. Sorted them correctly.

FitseTLT · 2026-03-16T15:06:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

2026-03-16.18-42-25.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

FitseTLT · 2026-03-16T15:06:20Z

@MelvinBot merge main

…ssibilityLabel Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot · 2026-03-16T15:11:24Z

Merged main into this branch.

codecov · 2026-03-16T15:36:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Picker/BasePicker.tsx	`54.54% <100.00%> (+0.59%)`	⬆️
... and 12 files with indirect coverage changes

FitseTLT

LGTM

melvin-bot · 2026-03-16T15:56:36Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #77534 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

FitseTLT · 2026-03-16T16:00:08Z

@MelvinBot make it ready for review

MelvinBot · 2026-03-16T16:01:34Z

PR has been marked as ready for review.

melvin-bot · 2026-03-16T16:01:37Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2026-03-16T18:58:28Z

@MelvinBot Change the test steps to

Precondition

you should be signed out

Using iOS VoiceOver, open the Expensify app
Swipe to the language dropdown button and double-tap to activate
Swipe to the 'Done' button
Swipe once left to focus to the done button
Verify that it announces it as 'Dismiss' button

MelvinBot · 2026-03-16T19:01:06Z

Updated the Tests and QA Steps sections with the new test steps.

rushatgabhane

LGTM

github-actions · 2026-03-16T20:09:51Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T20:14:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85103.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a0644d6-03346cd-6e767c9c7e5e45305f3fabe687886df6dead7db1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a0644d6-03346cd-17cb72b46ff698009f95e6deec623d99527dd40a/index.html

Web 🕸️
https://85103.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T20:20:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:56:14Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:03:20Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Add accessibilityLabel to picker dismiss button

930a49c

Pass accessibilityLabel with 'Dismiss' copy via touchableDoneProps in BasePicker so the iOS picker dismiss button is announced by VoiceOver. Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

MelvinBot assigned FitseTLT Mar 12, 2026

MelvinBot requested a review from a team March 12, 2026 15:36

MelvinBot mentioned this pull request Mar 12, 2026

[$250] Screen Reader: Sign in: The button to dismiss the picker view is not announced #77534

Open

Fix: sort imports alphabetically to pass Prettier check

ebbc54d

Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into claude-addDismissAcce…

e8d0111

…ssibilityLabel Co-authored-by: Fitsum Abebe <FitseTLT@users.noreply.github.com>

FitseTLT approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from arosiclair March 16, 2026 15:56

MelvinBot marked this pull request as ready for review March 16, 2026 16:01

MelvinBot requested a review from a team as a code owner March 16, 2026 16:01

melvin-bot bot requested review from FitseTLT and trjExpensify and removed request for a team March 16, 2026 16:01

melvin-bot bot removed the request for review from a team March 16, 2026 16:01

FitseTLT approved these changes Mar 16, 2026

View reviewed changes

rushatgabhane approved these changes Mar 16, 2026

View reviewed changes

arosiclair approved these changes Mar 16, 2026

View reviewed changes

arosiclair merged commit a0644d6 into main Mar 16, 2026
44 checks passed

arosiclair deleted the claude-addDismissAccessibilityLabel branch March 16, 2026 20:09

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

Conversation

MelvinBot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

MelvinBot commented Mar 12, 2026

Uh oh!

MelvinBot commented Mar 12, 2026

Uh oh!

FitseTLT commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Mar 16, 2026

Uh oh!

MelvinBot commented Mar 16, 2026

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

FitseTLT commented Mar 16, 2026

Uh oh!

MelvinBot commented Mar 16, 2026

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

FitseTLT commented Mar 16, 2026

Uh oh!

MelvinBot commented Mar 16, 2026

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Mar 12, 2026 •

edited

Loading

FitseTLT commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading