[NO QA] Add Propagation of Derived Parameters to Dynamic Routes State by collectioneur · Pull Request #85079 · Expensify/App

collectioneur · 2026-03-12T13:37:27Z

Explanation of Change

Propagate parent route params to dynamic route leaf nodes. getStateForDynamicRoute now accepts an optional parentRouteParams argument and merges it with query params on the leaf node. getStateFromPath passes the focused route's params through. Now dynamic routes retain all parent context in the navigation state.

Fixed Issues

$ #85055

Tests

Open the app and navigate to Settings > Profile > Address
Select any address field that opens the country selector (e.g. tap on the Country row), so the URL becomes something like /settings/profile/address/country?country=US
Verify that the country selector page opens correctly and the country query parameter is preserved (the correct country is pre-selected)
Verify that no errors appear in the JS console related to missing params or navigation state

No QA

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…agating

WojtekBoman · 2026-03-12T15:02:31Z

src/libs/Navigation/helpers/dynamicRoutesUtils/getStateForDynamicRoute.ts

                name: currentRoute ?? '',
                path,
-                params,
+                ...(mergedParams ? {params: mergedParams} : {}),


NAB: can't we create params object above, and here just pass it?

melvin-bot · 2026-03-12T15:26:03Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-12T15:42:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...pers/dynamicRoutesUtils/getStateForDynamicRoute.ts	`96.66% <100.00%> (+10.95%)`	⬆️
src/libs/Navigation/helpers/getStateFromPath.ts	`86.95% <100.00%> (ø)`
... and 218 files with indirect coverage changes

huult · 2026-03-12T15:52:20Z

@collectioneur Please ping me when it's ready.

hungvu193 · 2026-03-12T16:01:45Z

Oops I'm testing this. Just to confirm doesn this need C+ review 😂 @mjasikowski ? Otherwise, please unassign me here

mjasikowski · 2026-03-12T16:05:09Z

@hungvu193 sorry, auto assigner is crazy today. @huult will be doing the review

huult · 2026-03-13T14:39:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-13.at.21.54.39.mov

huult · 2026-03-13T15:00:28Z

src/libs/Navigation/helpers/dynamicRoutesUtils/getStateForDynamicRoute.ts

-        // If this is the last route, create leaf node with path
+        // If this is the last route, create leaf node with path and merged params
        if (currentIndex === routes.length - 1) {
+            const mergedParams = parentRouteParams || params ? {...parentRouteParams, ...params} : undefined;


I checked this yesterday and noticed that params can possibly be undefined. Spreading undefined may cause a runtime error: TypeError: Cannot convert undefined or null to object.

So to make this safer, I would recommend adding a fallback {}.

const mergedParams = parentRouteParams || params ? {...(parentRouteParams ?? {}), ...(params ?? {})} : undefined;

huult

LGTM!

github-actions · 2026-03-14T14:57:50Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-14T15:02:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85079.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-68a869e-65761aa-bf62663485b8a5636ceec9f148606d32cb47fe06/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-68a869e-65761aa-fb661b2a9e6e6922bf08f0f71671c8f8a3a3ebe4/index.html

Web 🕸️
https://85079.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-14T15:09:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

collectioneur added 2 commits March 12, 2026 14:32

add parameters propagating to dynamic routes state

d926cf7

Merge branch 'main' into collectioneur/dynamic-routes-parameters-prop…

7743f77

…agating

melvin-bot bot assigned collectioneur Mar 12, 2026

collectioneur changed the title ~~Collectioneur/dynamic routes parameters propagating~~ [NO QA] Add Propagation of Derived Parameters to Dynamic Routes State Mar 12, 2026

WojtekBoman reviewed Mar 12, 2026

View reviewed changes

WojtekBoman approved these changes Mar 12, 2026

View reviewed changes

collectioneur marked this pull request as ready for review March 12, 2026 15:25

collectioneur requested review from a team as code owners March 12, 2026 15:25

melvin-bot bot requested a review from hungvu193 March 12, 2026 15:26

melvin-bot bot requested review from heyjennahay and removed request for a team March 12, 2026 15:26

collectioneur mentioned this pull request Mar 12, 2026

migrate REPORT_SETTINGS_NAME #85034

Open

53 tasks

cleanup

961418f

mjasikowski assigned huult Mar 12, 2026

mjasikowski removed request for heyjennahay and hungvu193 March 12, 2026 16:05

mjasikowski self-assigned this Mar 12, 2026

mjasikowski requested a review from huult March 12, 2026 17:36

huult reviewed Mar 13, 2026

View reviewed changes

ensure that params aren't undefined

88b4337

huult approved these changes Mar 13, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski March 13, 2026 15:25

mjasikowski approved these changes Mar 14, 2026

View reviewed changes

mjasikowski merged commit 68a869e into Expensify:main Mar 14, 2026
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] Add Propagation of Derived Parameters to Dynamic Routes State#85079

[NO QA] Add Propagation of Derived Parameters to Dynamic Routes State#85079
mjasikowski merged 4 commits intoExpensify:mainfrom
software-mansion-labs:collectioneur/dynamic-routes-parameters-propagating

collectioneur commented Mar 12, 2026 •

edited

Loading

Uh oh!

WojtekBoman Mar 12, 2026

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

codecov bot commented Mar 12, 2026 •

edited by github-actions bot

Loading

Uh oh!

huult commented Mar 12, 2026

Uh oh!

hungvu193 commented Mar 12, 2026

Uh oh!

mjasikowski commented Mar 12, 2026

Uh oh!

huult commented Mar 13, 2026 •

edited

Loading

Uh oh!

huult Mar 13, 2026 •

edited

Loading

Uh oh!

huult left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

OSBotify commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

collectioneur commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

WojtekBoman Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 12, 2026

Uh oh!

codecov bot commented Mar 12, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Mar 12, 2026

Uh oh!

hungvu193 commented Mar 12, 2026

Uh oh!

mjasikowski commented Mar 12, 2026

Uh oh!

huult commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

github-actions bot commented Mar 14, 2026

Uh oh!

OSBotify commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

collectioneur commented Mar 12, 2026 •

edited

Loading

codecov bot commented Mar 12, 2026 •

edited by github-actions bot

Loading

huult commented Mar 13, 2026 •

edited

Loading

huult Mar 13, 2026 •

edited

Loading