Skip to content

Fix search not re-rendering when report display name changes #84391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinpersaud merged 15 commits into from
Mar 23, 2026
Merged

Fix search not re-rendering when report display name changes #84391

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4064938
Update option display names when derived reportAttributes change
MelvinBot Mar 6, 2026
b17d361
Replace reportAttributes effect with Chronos display name constant
MelvinBot Mar 9, 2026
43ee364
Fix: Sort imports to match Prettier configuration
MelvinBot Mar 9, 2026
b1ac72f
Fix Chronos display name overriding Concierge in report name resolution
MelvinBot Mar 9, 2026
db2c0f5
Merge remote-tracking branch 'origin/main' into claude-fixChronosDisp…
MelvinBot Mar 19, 2026
2bb44a7
Re-apply Chronos display name changes after merge with main
MelvinBot Mar 19, 2026
86b6728
Remove stale old-version sentry patch files
MelvinBot Mar 19, 2026
abf32aa
Remove stale files from old branch base that no longer exist on main
MelvinBot Mar 19, 2026
4c25d82
Add Chronos display name override in PersonalDetailsUtils
MelvinBot Mar 19, 2026
dccf47f
Fix: Compare report text in shallowOptionsListCompare to trigger re-r…
MelvinBot Mar 20, 2026
0c302a2
Merge remote-tracking branch 'origin/main' into claude-fixChronosDisp…
MelvinBot Mar 20, 2026
8378114
Remove all changes except shallowOptionsListCompare text comparison
MelvinBot Mar 20, 2026
6540944
Merge main to fix orphan branch history
MelvinBot Mar 20, 2026
38d096e
Merge remote-tracking branch 'origin/main' into claude-fixChronosDisp…
MelvinBot Mar 23, 2026
035badc
Remove stale files from orphan branch after merge with main
MelvinBot Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/libs/OptionsListUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@
*/

let allReports: OnyxCollection<Report>;
Onyx.connect({

Check warning on line 210 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check warning on line 210 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand All @@ -219,7 +219,7 @@
const allSortedReportActions: Record<string, ReportAction[]> = {};
const cachedOneTransactionThreadReportIDs: Record<string, string | undefined> = {};
let allReportActions: OnyxCollection<ReportActions>;
Onyx.connect({

Check warning on line 222 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check warning on line 222 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
waitForCollectionCallback: true,
callback: (actions) => {
Expand Down Expand Up @@ -264,7 +264,7 @@
});

let activePolicyID: OnyxEntry<string>;
Onyx.connect({

Check warning on line 267 in src/libs/OptionsListUtils/index.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.NVP_ACTIVE_POLICY_ID,
callback: (value) => (activePolicyID = value),
});
Expand Down Expand Up @@ -3319,7 +3319,9 @@
return false;
}
for (let i = 0; i < a.reports.length; i++) {
if (a.reports.at(i)?.reportID !== b.reports.at(i)?.reportID) {
const aReport = a.reports.at(i);
const bReport = b.reports.at(i);
if (aReport?.reportID !== bReport?.reportID || aReport?.text !== bReport?.text) {
return false;
}
}
Expand Down
Loading