feat: Update option missing for Personal Bank Accounts in ND compared to Classic#80020
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04a4154be9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@TaduJR Any update here? |
|
kindly bump @TaduJR |
|
Bump @TaduJR |
Hi @dukenv0307 Already replied 3 days ago. We are awaiting for clarifications on this #80020 (comment) |
|
@TaduJR Ah I see now. Thank you |
I tested on self hosted BE with chuck. |
Done |
|
@dukenv0307 This PR is more or less impossible to test without access to a backend dev environment, so when you're ready to checklist you can leave off the videos and leave that to me. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 686b8c034c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@TaduJR Can you please take a look at the comments above? And do you think we should disable the next button in offline mode like what we did in adding bank account flow? Screen.Recording.2026-03-16.at.09.39.18.mov |
|
The rest looks good |
…-option-missing-for-Personal-Bank-Accounts-in-ND-compared-to-Classic
I think the substeps already inherit the same |
…-option-missing-for-Personal-Bank-Accounts-in-ND-compared-to-Classic
This comment was marked as outdated.
This comment was marked as outdated.
…-option-missing-for-Personal-Bank-Accounts-in-ND-compared-to-Classic
…-option-missing-for-Personal-Bank-Accounts-in-ND-compared-to-Classic
…anup and restore error display
Done. |
…shared personalBankAccount key
…AccountID is missing
Oh It happened during rebase Done. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-19.at.20.02.20.movAndroid: mWeb ChromeScreen.Recording.2026-03-19.at.19.56.39.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2026-03-19.at.19.55.51.movMacOS: Chrome / SafariScreen.Recording.2026-03-19.at.18.54.58.mov |
|
@chuckdries can you please run the ad-hoc build then ask QA to test it. Thanks |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|

Explanation of Change
This PR adds an "Action required" badge and update flow for US personal bank accounts missing owner information (name, address, phone number), which is needed for global reimbursement payments to succeed.
What it does:
additionalDatafields (firstName,lastName,addressStreet,addressCity,addressState,addressZipCode,companyPhone)LegalNameStep,AddressStep,PhoneNumberStepfrom the international deposit account flow)UpdatePersonalBankAccountInfoAPI to save the dataadditionalDatawith rollback on failureFixed Issues
$ #76053
PROPOSAL: #76053 (comment)
Tests
Prerequisite: User with a US personal bank account missing personal info (name, address, or phone)
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Mac-Chrome.mp4