-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: footer text flickers in expensify card list #73642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
... and 274 files with indirect coverage changes 🚀 New features to boost your workflow:
|
src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx
Outdated
Show resolved
Hide resolved
|
Waiting for the next review here @rojiphil |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp73642-android-hybrid-001.mp4Android: mWeb Chrome73642-mweb-chrome-002.mp4iOS: HybridApp73642-ios-hybrid-001.mp4iOS: mWeb Safari73642-mweb-safari-002.mp4MacOS: Chrome / Safari73642-web-chrome-001.mp4MacOS: Desktop73642-desktop-001.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daledah for the PR.
@carlosmiceli Changes LGTM and works well too.
All yours. Thanks.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.43-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀
|
Explanation of Change
Fixed Issues
$ #73135
PROPOSAL: #73135 (comment)
Tests
Precondition
Offline tests
QA Steps
Precondition
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-29.at.02.19.37.mov
Android: mWeb Chrome
Screen.Recording.2025-10-29.at.02.21.18.mov
iOS: Native
Screen.Recording.2025-10-29.at.02.21.57.mov
iOS: mWeb Safari
Screen.Recording.2025-10-29.at.02.22.25.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-29.at.02.22.47.mov
MacOS: Desktop
Screen.Recording.2025-10-29.at.02.23.17.mov