-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/theme redesign #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for loquacious-pastelito-9eaca0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@saadamir3180 what changes are done in the service pages? |
The main change is how they link to each other. I created three parent services, as displayed on the landing page (can be changed). For now, each parent has two sub-services (more can be added). I also changed the behavior of the navigation bar for services. Now, the actual our-services route isn't there, only the sub-services are |
|
@saadamir3180 what about layout of the services page? That's a work pending, right? |
njmulsqb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
Portfolio should've the same drop-down as that of "Our services". There won't be a combined portfolio in the site e.g. |
|
Reduce navbar logo size by 40% |
|
The comparison table isn't responsive on smaller screens i.e. mobile. |
Services Page:The flow will be: |
are you talking about shifting services page to markdown? if yes markdown is already being implemented and is on the separate branch |
The testimonial length varies, so black spaces appear. We can either fix the card size to match the tallest card. If that's the case, let me know I was unable to implement the video testimonial thing even though i spend so much time, i'll give it one more try I'll add the slider for the images as well |
I didn't get your point. do we have a services page? |
No, I am talking about the layout of services page, that Tayyub has explained in his comment: #110 (comment) |
I am open to solutions, it should look uniform. May-be we can alter font-size to fit in a fixed-size card?
That's required
A separate slider isn't needed. Single slider will be used that will tackle both text and image of testimonial |
Check comparison table of https://www.persuasionexperience.com/ on mobile screen, you'll get the idea. |
|
I think a single slider will look weird when they slide, I suggest using separate sliders for the image and testimonial and synchronizing them, let me know your thoughts on this |
As Discussed before we'll have one main landing page and each service will have it's own landing page as well, the structure I have shared with you is for the landing page of each service |
The whole purpose is to show testimonial text along with the image of client, how will that be achieved in different sliders? |
currently only the testimonial text is in the slider, we can add a slider to the image also. By this the design will be the same, but when the testimonial slide changes the image also changes and vice versa |
|
@saadamir3180 Pause working on Testimonial section for now, I'll provide the Figma design for implementation. |
develops parent child relation between services
fix theme issues, make pricing section responsive, remove extra buttons from hero section, submenu UI fix, removed centralized portfolio
adds a dropdown to filter blogs based on tags and categories, removes tags and categories sub sections from aside, removes categories and tag routes from blogs
This is the current portfolio page: This is what I want it to be: For now only change the "Design" service portfolio page to what I've provided. |
Noted |
what should be the solution? |
The spacing should be consistent, the size of the cards should be consistent, for scenarios when then feedback exceeds the limit cut it off and have a button to expand it in case someone wants to read the full feedback |
|
@saadamir3180 For the comparison table, I mentioned earlier to show some options as the current one is too simple, any update on that? |
what do you mean by options? |
Options - Multiple comparison table styles to choose from |
Are you asking to design 2-3 comparison tables with different styling? |
Have you designed the comparison table by yourself or have used a pre-made one? |
Designed it by myself buddy :) |
Do confirm if we have the option of using pre-built ones |
|
@saadamir3180 Do let me know when the updates are done |
No, we don't |
This will again be a custom solution, we don't already have this behavior in template. If you want me to do so kindly share some sample designs |
@njmulsqb confirm please! |
He is busy, let's pause this for now and complete the rest |
change video to youtube iframe, fix nav for porfolio items, change theme for portfolio, fix active nav for mobile and desktop
@saadamir3180 Can't see this implementation on the website |
|
|
|
We're not going to list individual portfolio items in the menu, there will be main menu and a sub-menu, each sub menu entry will lead to its dedicated portfolio page that will list the portfolio items. |
and i hope there aren't additional pages for parent portfolios like Development, Cybersecurity... |
There won't be any. Check #110 (comment) Please read comments carefully. |
restructre portfolio pages to match service page structure
|
Why is this show projects button greyed out on services page? It should redirect to that service's portfolio page, see #110 (comment) |
Najam for this service we don't have any portfolio link, attached with it. We can update that particular service |












Redesign the landing page, re-structure the services pages
EDITED by @njmulsqb
For your ease @saadamir3180 here are the pending items: