Fixes inaccessible memory errors when running on Frontier with latest Trilinos. #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddement
force-pushed
the
fix_failing_unit_tests_with_new_trilinos
branch
2 times, most recently
from
58852e4
to
c6190c4
Compare
ddement
force-pushed
the
fix_failing_unit_tests_with_new_trilinos
branch
from
c6190c4
to
028067b
Compare
psakievich
approved these changes
Jun 7, 2023
Kokkos::deep_copy requires both views to have the same layout. The previous implementation copied from a layout left host view to a layout right device view. A host mirror is used in this case to ensure a consistent layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.