Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about development infrastructure #1119

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

neumantm
Copy link
Contributor

Resolves #1105

@neumantm
Copy link
Contributor Author

For me the bullet point list still does not render correctly.
Is that a problem on my side? Or are bullet points not supported in the nalu-wind docs?

@neumantm
Copy link
Contributor Author

Ok when rendered by readTheDocs, the bullet points are correct (at least with my own rtd project).
(See https://neumantm-nalu-wind--2.org.readthedocs.build/en/2/source/developer/infra.html)

Seems that is either a problem with building the docs outside of rtd or with my local installation.
Could anyone check if they also have that problem?

@psakievich psakievich enabled auto-merge (squash) April 8, 2023 21:00
@psakievich psakievich closed this Apr 8, 2023
auto-merge was automatically disabled April 8, 2023 21:02

Pull request was closed

@psakievich psakievich reopened this Apr 8, 2023
@psakievich psakievich enabled auto-merge (squash) April 8, 2023 21:02
@marchdf marchdf disabled auto-merge July 30, 2024 21:47
@marchdf
Copy link
Contributor

marchdf commented Jul 30, 2024

@psakievich feels like this should have been merged? It is approved and all.

Copy link
Contributor

@psakievich psakievich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall why it wasn't merged. Found one minor tweak due to infrastructure changes.

docs/source/developer/infra.rst Show resolved Hide resolved
@marchdf marchdf enabled auto-merge (rebase) July 30, 2024 21:56
@marchdf marchdf disabled auto-merge July 31, 2024 15:52
@marchdf marchdf merged commit 7c3e8a9 into Exawind:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend project development infrastructure documentation
3 participants