Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend project development infrastructure documentation #1105

Open
neumantm opened this issue Jan 12, 2023 · 5 comments · May be fixed by #1119
Open

Extend project development infrastructure documentation #1105

neumantm opened this issue Jan 12, 2023 · 5 comments · May be fixed by #1119
Assignees

Comments

@neumantm
Copy link
Contributor

As an external contributor I'd appreciate to have more documentation about the existing software development infrastructure.
This would help understanding how things work and what is going on.

Specific points I'm thinking about:

  • About the docker container ecpe4s/exawind-snapshot
    • Where is it defined? / What is the Dockerfile?
    • How, when, from which version of the Dockerfile is it built? / What exactly is the workflow for building it? / Where is the ci building it defined?
  • (Less important, as it can be determined by reading the ci definition) What does the ci do?
    • Which static analysis is run?
    • Does it also check the docs?
    • Which tests does the ci run and which tests does the ci not run?
@psakievich
Copy link
Contributor

@neumantm the docker container is created for us by an external collaborator in the E4S project. @eugeneswalker will you provide the link to the correct repo that contains the definition?

Essentially it is just a base ubuntu image with a [email protected] pre-installed. We then use spack-manager to install exawind+hypre+openfast.

The CI re-uses all the TPLS and then just rebuild nalu-wind, and we only run the unit-tests. I'd like to add in a subset of regression tests at some point too, but we currently don't store up-to-date golds in the repo so we'd need to update that process for the CI.

That static analysis right now is only doing a style check of the cpp code and doesn't check docs. We are using clang-format from clang@13 for our style checks.

Improving the CI is definitely something on the todo list so if you want to contribute there we'd be more than happy to have the assistance 😁.

@eugeneswalker
Copy link

@neumantm the docker container is created for us by an external collaborator in the E4S project. @eugeneswalker will you provide the link to the correct repo that contains the definition?

The Dockerfile and CI are here:

This runs once a day, in the morning, and generates the exawind-snapshot container image and pushes it to DockerHub.

@neumantm
Copy link
Contributor Author

Thank you for this infos.
I'd create a MR adding this to the developer docs, if that is alright.

neumantm added a commit to neumantm/nalu-wind that referenced this issue Jan 29, 2023
@neumantm neumantm linked a pull request Jan 29, 2023 that will close this issue
neumantm added a commit to neumantm/nalu-wind that referenced this issue Jan 29, 2023
neumantm added a commit to neumantm/nalu-wind that referenced this issue Feb 7, 2023
@psakievich
Copy link
Contributor

@neumantm the docker container is created for us by an external collaborator in the E4S project. @eugeneswalker will you provide the link to the correct repo that contains the definition?

The Dockerfile and CI are here:

This runs once a day, in the morning, and generates the exawind-snapshot container image and pushes it to DockerHub.

@ajpowelsnl this is the docker container you should look at to see how we use spack-manager. I gave you the wrong link in our meeting the other day.

@ajpowelsnl
Copy link
Contributor

Hi @psakievich, @jrood-nrel -- Thanks! I'll look into getting this info into the working base image on Perlmutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants