Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outer loop iteration capability between AMR-Wind and Nalu-Wind within each timestep #80

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

itopcuoglu
Copy link
Contributor

No description provided.

@itopcuoglu itopcuoglu changed the title Non-linear iteration capability between AMR-Wind and Nalu-Wind within each timestep Outer loop iteration capability between AMR-Wind and Nalu-Wind within each timestep Sep 9, 2024
@itopcuoglu itopcuoglu marked this pull request as ready for review September 13, 2024 17:52
@marchdf
Copy link
Contributor

marchdf commented Sep 13, 2024

Does this depend on any other PR or can it just go in now? If it depends on others, let's note that here and make this a draft.

@itopcuoglu itopcuoglu marked this pull request as draft September 13, 2024 21:27
@itopcuoglu
Copy link
Contributor Author

This requires the AMR-Wind commit to be merged first as the function prototype for incflo:;do_advance() in AMR-Wind has changed. I am converting it to draft.

@marchdf
Copy link
Contributor

marchdf commented Oct 9, 2024

Depends on Exawind/amr-wind#1226 so the CI will only pass once that is merged.

@marchdf marchdf marked this pull request as ready for review October 15, 2024 16:07
@marchdf marchdf merged commit c8823f1 into Exawind:main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants