2D Pitching Fixed Wing #983
Conversation
…rom a user supplied input file for fixed wing cases.
|
@ET14 great job getting this set up! I've added a few commits for the sake of passing the CI tests and correcting a print statement. If there are more changes you plan to make, please perform "git pull" before making the changes. I can also add the 2D Gaussian -- we need that for other uses as well. |
@mbkuhn what do you think is the best way to implement the 2D Gaussian? We would need some information to orient the Gaussian in the right direction. |
…tatement for aoa update (pitch table is now in deg rather than in rad)
…into ET_pitching_wing
…ation to n+1/2 rather than n
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
… span to ensure force conservation 2) Option to disable fz actuator force 3) Option to use a velocity magnitude of unity for force calculation
|
@tonyinme do we want to generalize the options to
|
|
@ET14 I believe I have generalized the capabilities from your work. I put a new reg test in test/test_files/act_pitching_wing_2D that should serve as an example for the input arguments. Please try out that case and see if it does what you need it to. It would be great if you could add a pitch_timetable file to that test case, too. I will probably add a unit test or two before merging, but I think it's ready otherwise. By the way, the "get_either" and "query_either" changes are for something Tony requested -- they weren't needed to get this to work. |
|
@mbkuhn Thank you for restructuring this, looks great! I will test all the flags again and also add a pitch input table. |
…g span for the test case to match the domain width in the periodic direction
|
@mbkuhn I re-ran some of my previous pitching wing test cases with the code version which you restructured two weeks ago and I obtain the same results. So the 2D Gaussian seems to work fine and also disabling the vertical forcing produced the results I expected. |
…near_angle interpolation
|
reg tests passed. last thing is unit tests |
* was not used in actual code, only in unit_tests * flat_plate and fixed_wing inputs are not similar enough to warrant another function
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
requested changes addressed |
Add capabilities to read a pitch angle time series from user provided text file for the fixed wing actuator case.
The implementation is intended to work also for "2D" cases and still misses the implementation of a 2D Gaussian.