Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cppcheck suppressions #884

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Remove cppcheck suppressions #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0c542f
Remove some suppressions
marchdf Jul 20, 2023
602d7e0
More
marchdf Jul 20, 2023
882c3e3
you learn every day
marchdf Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion amr-wind/equation_systems/PDEOps.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ struct SrcTermOpBase

for (auto& src_name : src_terms) {
// Prefer to use emplace_back here
// cppcheck-suppress useStlAlgorithm
sources.emplace_back(PDE::SrcTerm::create(src_name, sim));
}
}
Expand Down
17 changes: 7 additions & 10 deletions amr-wind/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,13 @@ int main(int argc, char* argv[])
return 1;
}

// cppcheck-suppress knownConditionTrueFalse
if (argc >= 2) {
// Look for "-h" or "--help" flag and print usage
for (auto i = 1; i < argc; i++) {
const std::string param(argv[i]);
if ((param == "--help") || (param == "-h")) {
amr_wind::io::print_banner(MPI_COMM_WORLD, std::cout);
amr_wind::io::print_usage(MPI_COMM_WORLD, std::cout);
return 0;
}
// Look for "-h" or "--help" flag and print usage
for (auto i = 1; i < argc; i++) {
const std::string param(argv[i]);
if ((param == "--help") || (param == "-h")) {
amr_wind::io::print_banner(MPI_COMM_WORLD, std::cout);
amr_wind::io::print_usage(MPI_COMM_WORLD, std::cout);
return 0;
}
}

Expand Down
1 change: 0 additions & 1 deletion amr-wind/wind_energy/actuator/disk/uniform_ct_ops.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ private:
int m_out_freq{10};

public:
// cppcheck-suppress constParameter
explicit ProcessOutputsOp<UniformCt, ActSrcDisk>(
const UniformCt::DataType& data)
: m_data(data)
Expand Down
Loading