using mac vel within wall function. #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbkuhn
commented
Jul 12, 2023
mbkuhn
commented
- enables use of n+1/2 velocity when it's called for the viscous terms
* enables use of n+1/2 velocity when it's called for the viscous terms
gdeskos
reviewed
Jul 12, 2023
| @@ -210,9 +210,6 @@ void ABLVelWallFunc::wall_model( | |||
| // const amrex::Real vv = vold_arr(i, j, k, 1); | |||
| const amrex::Real uu = | |||
| 0.5 * (umac_arr(i, j, k) + umac_arr(i + 1, j, k)); | |||
| // Is this reasonable, to interpolate using the wall | |||
| // value? Or should I extrapolate using the two points | |||
| // above the wall? | |||
| const amrex::Real vv = | |||
| 0.5 * (vmac_arr(i, j, k) + umac_arr(i, j + 1, k)); | |||
There was a problem hiding this comment.
Please make sure that you don't mix vmac_arr with umac_arr !
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+353
to
+354
| // const amrex::Real uu = vold_arr(i, j, k, 0); | ||
| // const amrex::Real vv = vold_arr(i, j, k, 1); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+209
to
+210
| // const amrex::Real uu = vold_arr(i, j, k, 0); | ||
| // const amrex::Real vv = vold_arr(i, j, k, 1); |
Check notice
Code scanning / CodeQL
Commented-out code Note
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.