Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of fixed point iterations if not taking any #1306

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Remove mention of fixed point iterations if not taking any #1306

merged 1 commit into from
Oct 21, 2024
+4 −2

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Oct 21, 2024

Summary

Remove mention of fixed point iterations if not taking any.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@marchdf marchdf enabled auto-merge (squash) October 21, 2024 22:02
mbkuhn
mbkuhn approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mbkuhn mbkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with this change. Not sure what this will look like for the hybrid solver side, Ilker might have input.

@marchdf marchdf merged commit eec57d1 into Exawind:main Oct 21, 2024
15 checks passed
itopcuoglu
itopcuoglu reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@itopcuoglu itopcuoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itopcuoglu itopcuoglu itopcuoglu left review comments

@mbkuhn mbkuhn mbkuhn approved these changes

@moprak-nrel moprak-nrel moprak-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marchdf @mbkuhn @itopcuoglu @moprak-nrel