Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing file in RegTests #1290

Closed
wants to merge 0 commits into from

Conversation

hgopalan
Copy link
Contributor

Summary

This PR fixes the missing file in the RegTests

Pull request type

Please check the type of change introduced:

  • [X ] Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • [X ] new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@hgopalan hgopalan requested a review from marchdf October 14, 2024 22:10
@hgopalan hgopalan linked an issue Oct 14, 2024 that may be closed by this pull request
@marchdf
Copy link
Contributor

marchdf commented Oct 14, 2024

Awesome! Would you mind removing the png and then making sure that terrain_box test also has a terrain file?

@jrood-nrel
Copy link
Contributor

I would recommend to rebase this PR so there aren't so many commits associated with this small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants