Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean Waves: target velocity given to added liquid in numerical beach #1283

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 10, 2024

Summary

Same idea as #1264, but for the numerical beach instead of the wave generation zone

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Likely no diffs on ow_* regression tests because they don't run long enough to hit numerical beach. I'll add a test to change that.

@mbkuhn mbkuhn requested a review from mpolimeno October 10, 2024 20:36
@mbkuhn mbkuhn changed the title Ocean Waves: give added liquid target velocity in numerical beach Ocean Waves: target velocity given to added liquid in numerical beach Oct 10, 2024
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Oct 10, 2024

there are very small diffs with ow_linear and ow_stokes, as expected. new regression test is set up to better test numerical beach functionality by initializing with a full wave field, which is present in the outlet region from the very beginning.

@mbkuhn mbkuhn force-pushed the ow_target_momentum_numerical_beach branch from ff3747f to 0602b93 Compare October 10, 2024 22:39
@mbkuhn mbkuhn marked this pull request as ready for review October 10, 2024 22:39
@mbkuhn mbkuhn requested a review from marchdf October 11, 2024 14:30
@mbkuhn mbkuhn merged commit 1cfd5f9 into Exawind:main Oct 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants