Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ocean Waves: expand area of valid target wave velocity for all current wave types #1282

Merged
merged 9 commits into from
Oct 10, 2024
Merged

Ocean Waves: expand area of valid target wave velocity for all current wave types #1282

merged 9 commits into from
Oct 10, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 10, 2024

Summary

I saw that some cells with tiny amounts of target_vof had a target velocity of 0. This PR expands where the target velocity is populated according to the wave profile and should eliminate the issue.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Could lead to small diffs for the ocean waves cases. Might not lead to any, though, because it is likely to only show up with sufficient cell resolution around the interface.

@mbkuhn mbkuhn enabled auto-merge (squash) October 10, 2024 19:47
@mbkuhn mbkuhn merged commit a047bbf into Exawind:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbkuhn @marchdf