Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests (and slight tweak) for ocean wave utils #1281

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 10, 2024

Summary

I wasn't sure if I could trust some of these functions, so I wrote unit tests. Turns out they're good.

I made a slight tweak but it shouldn't make a difference because of conditionals elsewhere when the function is called.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): better unit test coverage

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@mbkuhn mbkuhn requested a review from marchdf October 10, 2024 17:32
@mbkuhn mbkuhn force-pushed the ocean_wave_utils_unit_tests branch from 907e0b3 to abb6e6b Compare October 10, 2024 17:32
@mbkuhn mbkuhn force-pushed the ocean_wave_utils_unit_tests branch from abb6e6b to 39caeb8 Compare October 10, 2024 19:16
@mbkuhn mbkuhn enabled auto-merge (squash) October 10, 2024 19:17
@mbkuhn mbkuhn disabled auto-merge October 10, 2024 19:43
@mbkuhn mbkuhn force-pushed the ocean_wave_utils_unit_tests branch from aefb30b to e3dbfa1 Compare October 10, 2024 20:32
@mbkuhn mbkuhn enabled auto-merge (squash) October 10, 2024 20:33
@mbkuhn mbkuhn merged commit 7d6eb8d into Exawind:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants