Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warning for ABL inflow planes. #1278

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

lawrenceccheung
Copy link
Contributor

Summary

Currently when boundary plane faces are used on the xhi or yhi faces, amr-wind outputs the following warning:

We typically don't inflow boundary planes on the high side.!

However, depending on the wind direction, boundary planes can be on the xhi or yhi faces, and AMR-Wind should be capable of handling them.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

Issue Number:

@marchdf
Copy link
Contributor

marchdf commented Oct 9, 2024

Thanks for looking at this! I agree that it should be able to handle it and that it should work. At the time, I wasn't able to confirm it. Were you able to confirm that it can actually do it on the high end? That would be fantastic.

@marchdf marchdf self-requested a review October 9, 2024 19:14
@lawrenceccheung
Copy link
Contributor Author

Yes, I tested this on a case with a combination of ylo+xhi boundary inflow surfaces, and it seemed to work well. Note: this case was also only using a level 0 grid.

@marchdf marchdf disabled auto-merge October 10, 2024 17:11
@marchdf marchdf enabled auto-merge (squash) October 10, 2024 17:11
@marchdf marchdf merged commit b71cb96 into Exawind:main Oct 10, 2024
15 checks passed
@marchdf marchdf mentioned this pull request Oct 11, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants